Skip to content

feat: Add maui-startup-profiling skill for PR #60 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jfversluis wants to merge 1 commit into from
Closed

feat: Add maui-startup-profiling skill for PR #60 #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 17 additions & 28 deletions .github/workflows/pr-docs-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
description: |
Analyzes merged pull requests for documentation needs. When a PR is merged,
this workflow reviews the changes and determines if documentation updates are
needed on dotnet/docs-maui. If updates are needed, it opens a draft PR directly
on docs-maui. If not, it comments on the source PR explaining why.
needed on dotnet/docs-maui. If updates are needed, it opens an issue on
docs-maui describing the suggested changes. If not, it comments on the source
PR explaining why.

on:
pull_request:
Expand Down Expand Up @@ -55,12 +56,10 @@ tools:

safe-outputs:
github-token: ${{ secrets.MAUI_BOT_TOKEN }}
create-pull-request:
title-prefix: "[maui-labs] "
create-issue:
title-prefix: "[maui-labs docs] "
labels: [docs-from-code]
draft: true
target-repo: "dotnet/docs-maui"
Comment on lines 57 to 62

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-docs-check.lock.yml is still configured to use create_pull_request with a "[maui-labs]" title prefix and draft PR behavior. With this prompt switching to create-issue and a different title prefix, the locked workflow will keep doing the old behavior (or the agent will request a tool that isn't allowlisted). Regenerate/update the lock workflow to match the new safe-outputs and tool expectations.

Copilot uses AI. Check for mistakes.

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new create-issue safe-output config is missing guardrails that other workflows in this repo use (e.g., max: 1 and optionally close-older-issues: true) to prevent opening multiple redundant issues. Consider adding those limits here as well so a burst of merges doesn’t spam dotnet/docs-maui.

Suggested change
target-repo: "dotnet/docs-maui"
target-repo: "dotnet/docs-maui"
max: 1
close-older-issues: true

Copilot uses AI. Check for mistakes.
expires: 30
add-comment:
hide-older-comments: true

Expand Down Expand Up @@ -165,35 +164,25 @@ Also check:
- `docs/developer-tools/index.md` — Landing page for the developer-tools section
- `docs/TOC.yml` — Table of contents (update if adding new pages)

Before making changes, check if there are any open draft PRs on `dotnet/docs-maui`
with the `docs-from-code` label from recent maui-labs merges. If so, note any
potential conflicts in your PR description.
### 4b: Open an Issue on docs-maui

The documentation is written in Microsoft Learn Markdown format:
- Use `> [!NOTE]`, `> [!WARNING]`, `> [!TIP]` for callout boxes
- Use `ms.date: MM/DD/YYYY` format in frontmatter
- Code blocks use triple backticks with language identifier
- Tables use pipe syntax
Create an issue on `dotnet/docs-maui` describing the documentation updates needed.
The issue should include:

### 4b: Open a Draft PR on docs-maui
- **Which pages** need updating (reference the file paths above)
- **What changed** — summarize the user-facing changes from the PR
- **Suggested content** — provide the specific text, code blocks, or table rows
to add or modify so a docs author can apply the changes directly
- If a new page is needed, suggest the filename and where it fits in `docs/TOC.yml`

Make the changes to the appropriate documentation files and open a draft pull
request on `dotnet/docs-maui`. Match changes to the right page:
- CLI command changes → update the relevant `docs/developer-tools/cli/` page
- DevFlow feature changes → update the relevant `docs/developer-tools/devflow/` page
- New capabilities that don't fit existing pages → create a new page and add it to `docs/TOC.yml`

The PR should:
- Update the `ms.date` field in the frontmatter of changed files to today's date
- Include a clear PR title describing the documentation update
- In the PR body, link to the source PR in `dotnet/maui-labs` that triggered the change
- Keep changes minimal — only update what's needed for this specific PR
The issue body should be self-contained — a docs author should be able to make
the update without reading the full source PR diff.
Comment on lines +167 to +179

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section now directs the agent to open an issue, but earlier text still refers to opening a "docs PR" and says "Draft PRs are cheap". Update the remaining wording in the file to consistently describe the issue-based workflow (and avoid the agent deciding it should create a PR anyway).

Copilot uses AI. Check for mistakes.

### 4c: Comment on the Source PR

Comment on the original PR in `dotnet/maui-labs` with:
- A summary of the documentation changes made
- A link to the draft PR on `dotnet/docs-maui`
- A summary of the documentation changes suggested
- A link to the issue opened on `dotnet/docs-maui`

## Step 5: If Documentation is NOT Needed

Expand Down