feat: Add maui-startup-profiling skill for PR #60#85
Conversation
The workflow cannot push branches to dotnet/docs-maui cross-repo. Switch to creating an issue with suggested changes instead, which only requires issues:write permission on the target repo. The .lock.yml needs to be regenerated with 'gh aw compile'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the pr-docs-check agentic workflow prompt to shift from opening draft documentation PRs on dotnet/docs-maui to opening issues describing the needed doc changes.
Changes:
- Adjusts the workflow description and Step 4 guidance to instruct creating an issue on
dotnet/docs-mauiinstead of a draft PR. - Updates
safe-outputsconfiguration in the prompt to usecreate-issuewith a new title prefix.
| safe-outputs: | ||
| github-token: ${{ secrets.MAUI_BOT_TOKEN }} | ||
| create-pull-request: | ||
| title-prefix: "[maui-labs] " | ||
| create-issue: | ||
| title-prefix: "[maui-labs docs] " | ||
| labels: [docs-from-code] | ||
| draft: true | ||
| target-repo: "dotnet/docs-maui" |
There was a problem hiding this comment.
pr-docs-check.lock.yml is still configured to use create_pull_request with a "[maui-labs]" title prefix and draft PR behavior. With this prompt switching to create-issue and a different title prefix, the locked workflow will keep doing the old behavior (or the agent will request a tool that isn't allowlisted). Regenerate/update the lock workflow to match the new safe-outputs and tool expectations.
| title-prefix: "[maui-labs docs] " | ||
| labels: [docs-from-code] | ||
| draft: true | ||
| target-repo: "dotnet/docs-maui" |
There was a problem hiding this comment.
The new create-issue safe-output config is missing guardrails that other workflows in this repo use (e.g., max: 1 and optionally close-older-issues: true) to prevent opening multiple redundant issues. Consider adding those limits here as well so a burst of merges doesn’t spam dotnet/docs-maui.
| target-repo: "dotnet/docs-maui" | |
| target-repo: "dotnet/docs-maui" | |
| max: 1 | |
| close-older-issues: true |
| ### 4b: Open an Issue on docs-maui | ||
|
|
||
| The documentation is written in Microsoft Learn Markdown format: | ||
| - Use `> [!NOTE]`, `> [!WARNING]`, `> [!TIP]` for callout boxes | ||
| - Use `ms.date: MM/DD/YYYY` format in frontmatter | ||
| - Code blocks use triple backticks with language identifier | ||
| - Tables use pipe syntax | ||
| Create an issue on `dotnet/docs-maui` describing the documentation updates needed. | ||
| The issue should include: | ||
|
|
||
| ### 4b: Open a Draft PR on docs-maui | ||
| - **Which pages** need updating (reference the file paths above) | ||
| - **What changed** — summarize the user-facing changes from the PR | ||
| - **Suggested content** — provide the specific text, code blocks, or table rows | ||
| to add or modify so a docs author can apply the changes directly | ||
| - If a new page is needed, suggest the filename and where it fits in `docs/TOC.yml` | ||
|
|
||
| Make the changes to the appropriate documentation files and open a draft pull | ||
| request on `dotnet/docs-maui`. Match changes to the right page: | ||
| - CLI command changes → update the relevant `docs/developer-tools/cli/` page | ||
| - DevFlow feature changes → update the relevant `docs/developer-tools/devflow/` page | ||
| - New capabilities that don't fit existing pages → create a new page and add it to `docs/TOC.yml` | ||
|
|
||
| The PR should: | ||
| - Update the `ms.date` field in the frontmatter of changed files to today's date | ||
| - Include a clear PR title describing the documentation update | ||
| - In the PR body, link to the source PR in `dotnet/maui-labs` that triggered the change | ||
| - Keep changes minimal — only update what's needed for this specific PR | ||
| The issue body should be self-contained — a docs author should be able to make | ||
| the update without reading the full source PR diff. |
There was a problem hiding this comment.
This section now directs the agent to open an issue, but earlier text still refers to opening a "docs PR" and says "Draft PRs are cheap". Update the remaining wording in the file to consistently describe the issue-based workflow (and avoid the agent deciding it should create a PR anyway).
|
will revisit skill/docs additions for maui profile startup after PR #60 merges.Closing |
Adds agent skill and documentation for
maui profile startup(from PR #60).Changes
plugins/dotnet-maui/skills/maui-startup-profiling/SKILL.mdtests/dotnet-maui/maui-startup-profiling/eval.yamlmaui profile startupto CLI command list.claude/skills/maui-ai-debugging/SKILL.md: added startup profiling section + updated description frontmatterNotes
This PR should ideally be merged after (or together with) PR #60 which adds the actual
maui profile startupcommand.