Change back previous version hashing of 8 byte types#5152
Merged
harishsk merged 3 commits intodotnet:masterfrom May 26, 2020
Merged
Change back previous version hashing of 8 byte types#5152harishsk merged 3 commits intodotnet:masterfrom
harishsk merged 3 commits intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5152 +/- ##
==========================================
+ Coverage 75.76% 75.77% +0.01%
==========================================
Files 993 993
Lines 180746 180876 +130
Branches 19463 19477 +14
==========================================
+ Hits 136944 137062 +118
- Misses 38516 38521 +5
- Partials 5286 5293 +7
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #5104 he hashing function of 8 byte numeric types was changed, but there still needs to be an unchanged implementation for old version models.
In addition, found a bug in ONNX conversion of hashing of keys that have underlying type different than uint.