Support more types for HashEstimator#5104
Merged
wangyems merged 17 commits intodotnet:masterfrom May 19, 2020
wangyems:wangye/hash
Merged
Support more types for HashEstimator#5104wangyems merged 17 commits intodotnet:masterfrom wangyems:wangye/hash
wangyems merged 17 commits intodotnet:masterfrom
wangyems:wangye/hash
Conversation
yaeldekel
reviewed
May 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
- Coverage 75.64% 75.59% -0.05%
==========================================
Files 990 990
Lines 179576 179222 -354
Branches 19308 19287 -21
==========================================
- Hits 135844 135488 -356
- Misses 38462 38471 +9
+ Partials 5270 5263 -7
|
Contributor
harishsk
reviewed
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Verified compatibility(change required in ML.NET in this PR) between ORT(microsoft/onnxruntime#3827) and ML.NET
-Some changes made in a couple of 64-bit hash function because the existed implementation is not exactly the same as MurmurHash3_x86_32
-bump to ort1.3 pre-release and fix some test cases