Skip to content

Disallow bad input types in FeatureSelection estimator's GetOutputSchema method#4702

Merged
yaeldekel merged 1 commit intodotnet:masterfrom
yaeldekel:featureselection
Jan 30, 2020
Merged

Disallow bad input types in FeatureSelection estimator's GetOutputSchema method#4702
yaeldekel merged 1 commit intodotnet:masterfrom
yaeldekel:featureselection

Conversation

@yaeldekel
Copy link

Related to #4693 .

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yaeldekel
Copy link
Author

    public void FeatureSelectionWorkout()

This test is now failing because of issue #969, so this PR should wait until PR #4696 is merged before it can be merged.


Refers to: test/Microsoft.ML.Tests/Transformers/FeatureSelectionTests.cs:27 in aae82c5. [](commit_id = aae82c5, deletion_comment = False)

@yaeldekel yaeldekel merged commit 74917b9 into dotnet:master Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants