Fix bug in WordBagEstimator when training on empty data#4696
Merged
yaeldekel merged 5 commits intodotnet:masterfrom Jan 30, 2020
Merged
Fix bug in WordBagEstimator when training on empty data#4696yaeldekel merged 5 commits intodotnet:masterfrom
yaeldekel merged 5 commits intodotnet:masterfrom
Conversation
harishsk
reviewed
Jan 23, 2020
|
|
||
| namespace Microsoft.ML.Transforms | ||
| { | ||
| internal sealed class MissingValueDroppingEstimator : TrivialEstimator<MissingValueDroppingTransformer> |
Contributor
There was a problem hiding this comment.
Is this useful in other cases? Do we need to add this to the catalog and make it public?
Author
There was a problem hiding this comment.
I don't think it is - seems to be something very specific to Ngram extraction.
In reply to: 370393234 [](ancestors = 370393234)
harishsk
reviewed
Jan 23, 2020
|
|
||
| internal static IDataTransform Create(IHostEnvironment env, Options options, IDataView input) => | ||
| (IDataTransform)CreateTransfomer(env, options, input).Transform(input); | ||
| (IDataTransform)CreateEstimator(env, options, SchemaShape.Create(input.Schema)).Fit(input).Transform(input)/* CreateTransfomer(env, options, input).Transform(input)*/; |
Contributor
There was a problem hiding this comment.
Nit: Can you please remove the commented code? #Resolved
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969 .
Related to issue #4693 .