Fix bad recursion causing no-extension files to go into nested subdirs #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Mar 17, 2023
directhex
added a commit
to directhex/icu
that referenced
this pull request
Mar 17, 2023
akoeplinger
pushed a commit
to dotnet/icu
that referenced
this pull request
Mar 17, 2023
Never use `%(RecursiveDir)%(Filename)%(Extension)` with Microsoft.DotNet.Build.Tasks.Packaging, as it may turn extensionless files into double-nested files (e.g. `a/b/c` -> `a/b/c/c` but `a/b/c.txt` will remain `a/b/c.txt`)
steveisok
pushed a commit
to steveisok/icu
that referenced
this pull request
May 25, 2023
Never use `%(RecursiveDir)%(Filename)%(Extension)` with Microsoft.DotNet.Build.Tasks.Packaging, as it may turn extensionless files into double-nested files (e.g. `a/b/c` -> `a/b/c/c` but `a/b/c.txt` will remain `a/b/c.txt`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this pattern in a pkgproj:
This installs, say,
in\a\b\c.txtto a directory in the nupkg ofout\a\b\c.txtHOWEVER
If a file has no extension (i.e.
in\a\b\c) then%(Extension)EXPANDS TO\cSO IT INSTALLS TOout\a\b\c\cThis is an adverse reaction to an intentional behaviour in Microsoft.DotNet.Build.Tasks.Packaging, work around it by only ever using TargetPath to emit to a directory, not a file.
Also fix a few errors in Wasm SDK packaging spotted at the same time.
ref https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Packaging/src/build/Packaging.targets#L458-L464