Skip to content

Fix recursion problem discovered in llvm-project#388 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix recursion problem discovered in llvm-project#388 #333

merged 1 commit into from
Mar 17, 2023

Conversation

@directhex
Copy link

@directhex directhex commented Mar 17, 2023 •
edited
Loading

Never use %(RecursiveDir)%(Filename)%(Extension) with Microsoft.DotNet.Build.Tasks.Packaging, as it may turn extensionless files into double-nested files (e.g. a/b/c -> a/b/c/c but a/b/c.txt will remain a/b/c.txt)

@akoeplinger akoeplinger enabled auto-merge (squash) March 17, 2023 15:44
@akoeplinger akoeplinger merged commit eb92d6d into dotnet:dotnet/main Mar 17, 2023
steveisok pushed a commit to steveisok/icu that referenced this pull request May 25, 2023
@directhex
Fix recursion problem discovered in dotnet/llvm-project#388 (dotnet#333)
cdfbb58 
Never use `%(RecursiveDir)%(Filename)%(Extension)` with Microsoft.DotNet.Build.Tasks.Packaging, as it may turn extensionless files into double-nested files (e.g. `a/b/c` -> `a/b/c/c` but `a/b/c.txt` will remain `a/b/c.txt`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@directhex @akoeplinger