Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Don't suppress all warnings with SuppressTrimAnalysisWarnings (#3003) #3005

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 25, 2022

Backport of #3003
Fixes #2982

…#3003)

This replaces
dotnet@82c6dc6
with a different approach. Now SuppressTrimAnalysisWarnings only
suppresses those warnings defined to be part of the "trim analysis"
category, using a separate command-line argument.  An exception is 5.0
apps, where the setting continues to suppress specific warnings for
compatibility.
@sbomer sbomer marked this pull request as ready for review August 25, 2022 22:51
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@sbomer sbomer merged commit abb08f9 into dotnet:release/7.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants