Don't suppress all warnings with SuppressTrimAnalysisWarnings #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Just to make sure I understand this, it looks like compared to #2930, we're just moving the logic for SuppressTrimAnalysisWarnings to the linker instead of MSBuild; is that right? And I guess custom steps can opt in to suppressing their warnings if they use the "TrimAnalysis" subcategory. Looks good to me if that's the case.
|
Yup, that's right. Instead of updating the |
sbomer
added a commit
to sbomer/linker
that referenced
this pull request
Aug 25, 2022
…#3003) This replaces dotnet@82c6dc6 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
sbomer
added a commit
that referenced
this pull request
Aug 29, 2022
…#3005) This replaces 82c6dc6 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…/linker#3003) This replaces https://github.com/dotnet/linker/commit/dotnet/linker@82c6dc6f82aeb90cfbe509ae07cf539eecb75550 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility. Commit migrated from dotnet/linker@b23be78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2930 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument.
An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
Fixes #2982