-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't suppress all warnings with SuppressTrimAnalysisWarnings #3003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I understand this, it looks like compared to #2930, we're just moving the logic for SuppressTrimAnalysisWarnings to the linker instead of MSBuild; is that right? And I guess custom steps can opt in to suppressing their warnings if they use the "TrimAnalysis" subcategory. Looks good to me if that's the case.
Yup, that's right. Instead of updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me :)
…#3003) This replaces dotnet@82c6dc6 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
…#3005) This replaces 82c6dc6 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
…/linker#3003) This replaces https://github.com/dotnet/linker/commit/dotnet/linker@82c6dc6f82aeb90cfbe509ae07cf539eecb75550 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument. An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility. Commit migrated from dotnet/linker@b23be78
This replaces #2930 with a different approach. Now SuppressTrimAnalysisWarnings only suppresses those warnings defined to be part of the "trim analysis" category, using a separate command-line argument.
An exception is 5.0 apps, where the setting continues to suppress specific warnings for compatibility.
Fixes #2982