Fix BlazorWasm projects #16260
Merged
Fix BlazorWasm projects #16260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
force-pushed
the
test.fix.main
branch
from
a738412 to
ae422fd
Compare
Member
Author
|
This is a backport of the change that is already in Preview 4: #16252 All checks are passing now - there was a conflict and a patch could not be applied. |
mthalman
approved these changes
Apr 28, 2023
This was referenced May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16252
Fixes: dotnet/source-build#3410
Razor source-generator was including SBRP package for
Microsoft.Extensions.ObjectPoolwhich resulted inMicrosoft.Extensions.ObjectPool.dllbeing a reference assembly. This was introduced with the followingrazorchange: dotnet/razor#8542Package version property was incorrect - source-build could not override with live version of
Microsoft.Extensions.ObjectPoolpackage.This PR does not address other instances of similarly named packages using
MicrosoftExtensionsPackageVersionproperty. There are no other reference assemblies in final, source-build produced, SDK.Also, re-enabling BlazorWasm test.