Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Apr 26, 2023

Fixes: dotnet/source-build#3410

Razor source-generator was including SBRP package for Microsoft.Extensions.ObjectPool which resulted in Microsoft.Extensions.ObjectPool.dll being a reference assembly. This was introduced with the following razor change: dotnet/razor#8542

Package version property was incorrect - source-build could not override with live version of Microsoft.Extensions.ObjectPool package.

This PR does not address other instances of similarly named packages using MicrosoftExtensionsPackageVersion property. There are no other reference assemblies in final, source-build produced, SDK.

Also, re-enabling BlazorWasm test.

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner April 26, 2023 22:32
@NikolaMilosavljevic NikolaMilosavljevic merged commit 53315e1 into dotnet:release/8.0.1xx-preview4 Apr 27, 2023
@NikolaMilosavljevic NikolaMilosavljevic changed the title Fix BlazorWasm projects [release/8.0.1xx-preview4] Fix BlazorWasm projects Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants