[Release/3.0] Set IsShipping=false for all TestingUtils projects #2781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the ref project(s) in this dir get the default value of
IsShipping=truefrom Arcade: https://github.com/dotnet/arcade/blob/0c9b0442f2ce607a90615a7bfad4ead069150bc6/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L18. This means that other projects which compile against ref projects in this folder (i.e.,Microsoft.Extensions.Logging.Testingcompiles againstMicrosoft.AspNetCore.Testing) will get non-suffixed versions for their dependencies. When we ship stable,Microsoft.Extensions.Logging.Testinglists a dependency on a stable version ofMicrosoft.AspNetCore.Testing, which does not exist.We should think of a better way to resolve this issue - for example, AspNetCore calculates a global default for
IsShipping, which would prevent this type of issue: https://github.com/aspnet/AspNetCore/blob/20fc1adf2ada01a4a1fc7934706d2b641acbb9f4/Directory.Build.props#L23It's also worth noting that
Microsoft.AspNetCore.Testingis unique in that it is a non-shipping project that has a ref assembly. We should understand why that ref assembly is needed, and decide if it can be removed (removing it caused some errors that seemed non-trivial to fix). The ref assembly was added in this PR: #2483CC @dougbu @JunTaoLuo @mmitche