Compile using ref assemblies #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Oct 10, 2019
src/Logging/Logging.Testing/src/Microsoft.Extensions.Logging.Testing.csproj
Outdated
Show resolved
Hide resolved
wtgodbe
reviewed
Oct 10, 2019
wtgodbe
reviewed
Oct 10, 2019
wtgodbe
reviewed
Oct 10, 2019
wtgodbe
approved these changes
Oct 10, 2019
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
LGTM other than the few comments
JunTaoLuo
added
the
servicing-consider
added 2 commits
October 10, 2019 10:53
dougbu
reviewed
Oct 10, 2019
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
I'll approve after the biggest change is categorized
| @@ -0,0 +1,7 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
This is fine but only if it is not creating a new (useless) package
Author
There was a problem hiding this comment.
It is being produced. Will remove.
JunTaoLuo
commented
Oct 10, 2019
Author
JunTaoLuo
left a comment
JunTaoLuo
left a comment
There was a problem hiding this comment.
@dougbu I marked out the two changes that are made for compiling against ref. Addressing Will's feedback mostly involved adding comments and removing errors that are irrelevant in Extensions so I'm not marking them out. The rest of the changes are just copied over from AspNetCore.
dougbu
approved these changes
Oct 11, 2019
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks good.
Please confirm no new Microsoft.Extensions.ProviderAliasUtilities.Sources package is created.
This was referenced Dec 12, 2019
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework\n\nCommit migrated from dotnet/extensions@e771c42
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework\n\nCommit migrated from dotnet/extensions@e771c42
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework Commit migrated from dotnet/extensions@e771c42
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework Commit migrated from dotnet/extensions@e771c42
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework Commit migrated from dotnet/extensions@e771c42
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework Commit migrated from dotnet/extensions@e771c42
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
* Compile using ref assemblies * Use updated ResolveReferences.target from AspNetCore * Generate ref assemblies for .NET framework Commit migrated from dotnet/extensions@e771c42
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/aspnet/AspNetCore-Internal/issues/1773