[SMALL] Fix to #21607 - Incorrect results returned when joining a key-less view to an entity #21723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @maumar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot require 1 approval |
|
Hello @maumar! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
maumar
commented
Jul 21, 2020
maumar
changed the title
smitpatel
reviewed
Jul 21, 2020
smitpatel
reviewed
Jul 21, 2020
test/EFCore.Cosmos.FunctionalTests/Query/NorthwindKeylessEntitiesQueryCosmosTest.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 21, 2020
test/EFCore.Specification.Tests/Query/NorthwindKeylessEntitiesQueryTestBase.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
fix21607
branch
2 times, most recently
from
a46c430 to
fadcb58
Compare
|
updated |
smitpatel
approved these changes
Jul 22, 2020
…ew to an entity Disabling the scenario when we try to add collection join to keyless entity parent, since we don't have identifying columns to properly bucket the results. Fixes #21607
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the scenario when we try to add collection join to keyless entity parent, since we don't have identifying columns to properly bucket the results.
Fixes #21607