Skip to content

Fix for modifying an enumerated collection while traversing it. #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 1 commit into from
Jul 18, 2023
Merged

Fix for modifying an enumerated collection while traversing it. #8972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Docfx.Build.Engine/XRefMaps/XRefCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,14 @@ public async Task<IXRefContainerReader> CreateAsync()
{
AddToDownloadList(_uris);
var dict = new Dictionary<string, IXRefContainer>();
foreach (var item in _processing)
while (_processing.Any())
{
var task = item.Key;
var uri = item.Value;
Task<IXRefContainer> task = await Task.WhenAny(_processing.Keys);
Uri uri = _processing[task];
_processing.Remove(task);
try
{
var container = await task;
IXRefContainer container = await task;
if (!container.IsEmbeddedRedirections)
{
AddToDownloadList(
Expand Down
2 changes: 2 additions & 0 deletions src/Docfx.Build.Engine/XRefMaps/XRefMapDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ protected static IXRefContainer DownloadFromLocal(Uri uri)

private static IXRefContainer ReadLocalFile(string filePath)
{
Logger.LogVerbose($"Reading from file: {filePath}");
if (".zip".Equals(Path.GetExtension(filePath), StringComparison.OrdinalIgnoreCase))
{
return XRefArchive.Open(filePath, XRefArchiveMode.Read);
Expand All @@ -120,6 +121,7 @@ private static IXRefContainer ReadLocalFile(string filePath)

protected static async Task<XRefMap> DownloadFromWebAsync(Uri uri)
{
Logger.LogVerbose($"Reading from web: {uri.OriginalString}");
var baseUrl = uri.GetLeftPart(UriPartial.Path);
baseUrl = baseUrl.Substring(0, baseUrl.LastIndexOf('/') + 1);

Expand Down