Fix for modifying an enumerated collection while traversing it. #8972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'll take the time to read the license agreement; but since this PR in its core is a revert to a previous version of the code, I make no claims of copyright, and the project is free to use its content without my involvement. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8972 +/- ##
==========================================
- Coverage 76.93% 76.93% -0.01%
==========================================
Files 605 605
Lines 25054 25057 +3
==========================================
+ Hits 19275 19277 +2
- Misses 5779 5780 +1
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@dotnet-policy-service agree |
Contributor
|
Thank you @mihtjel for fixing this! |
yufeih
added
the
bug-fix
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing version of XRefCollection's ReaderCreator attempts to add items to a collection while it is traversing the same collection using foreach, causing an AggregateException. This error can be seen by having a simple xrefmap.yml file (referred to by "xref" in docfx.json) containing two redirections:
This pull request reverts to a previous form of the loop, allowing the collection to be changed while processing it. Additionally, it adds a couple of log statements to XRefMapDownloader, enabled via
--logLevel verbose, to allow the user to see which XRefMaps are being read.