Delete old projects and remove failing samples from the solution. #2244
Conversation
| @@ -6,7 +6,6 @@ | |||
| <OutputType>Exe</OutputType> | |||
There was a problem hiding this comment.
Note that this sample was removed from the solution as it no longer builds (we removed System.Net.Libuv). What do we plan to do with this?
| @@ -5,7 +5,6 @@ | |||
| <OutputType>Exe</OutputType> | |||
There was a problem hiding this comment.
Note that this sample was removed from the solution as it no longer builds (we removed System.Net.Libuv). What do we plan to do with this?
There was a problem hiding this comment.
cc @KrzysztofCwalina, you wanted to keep this initially.
There was a problem hiding this comment.
Hmmm, we need to port it to use Sockets. Please file an issue and assign it to me. I will do it.
| @@ -4,8 +4,6 @@ | |||
|
|
|||
There was a problem hiding this comment.
Note that this entire sample project was removed from the solution as it no longer builds (we removed all the System.IO.Pipelines.* projects). What do we plan to do with this?
cc @davidfowl, @pakrym
| @@ -1,10 +0,0 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Are we removing Dec64 for good or just moving it to some temporary location? If we are removing it, I think we need to contact the owner first.
There was a problem hiding this comment.
We are removing it for good.
There is no steward within Microsoft for this.
@benaadams initiated it but it has been inactive since then:
#764
https://github.com/dotnet/corefx/issues/10951
|
Most of the code removed in this PR was added by @davidfowl. I would like @davidfowl to sign off on the removals. Otherwise looks good. |
| @@ -1,9 +0,0 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Similar to System.Numerics.Dec64, we are deleting System.Numerics.Matrices.
There is no steward/owner and the project has become inactive.
It was added here: #118 / dotnet/corefx#1846
|
RIP 👍 |
|
Did you delete the pipelines samples? |
No, I just removed it from the solution. It no longer builds because we removed the other System.IO.Pipelines.* projects. Should I remove it? |
Yes, nuke it. |
Part of corefxlab repo cleanup
cc @dotnet/corefxlab-contrib, @davidfowl, @pakrym, @JeremyKuhne, @atsushikan, @adamsitnik