Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Add tests for libuv component #822

Closed
KrzysztofCwalina opened this issue Sep 16, 2016 · 3 comments
Closed

Add tests for libuv component #822

KrzysztofCwalina opened this issue Sep 16, 2016 · 3 comments

Comments

@KrzysztofCwalina
Copy link
Member

No description provided.

@grahamehorner
Copy link

grahamehorner commented Dec 16, 2016

I'm happy to pick this up as I'm also doing some Libuv UDP work

however this leads me to a question with regards to what/where the libuv interop/wrapper functionality should be located as it seems that there is duplicated functionality at present in the pipelines & in system.net.libuv ? are these to be consolidated ? as my gut feel is that libuv interop/wrapper shouldn't be inside pipelines as it my be also used by channels ? @KrzysztofCwalina @davidfowl whats your view?

@KrzysztofCwalina
Copy link
Member Author

Ideally, we would have a raw libuv library which would be used by pipelines.

The problem is that it's much more difficult/costly to design a general purpose library like that, than just use libuv as an implementation detaail of pipelines.

But, if you wanted to work on the libuv library, and make it into a nice reusable component, it would be great and I think @davidfowl would like to use it (confirm?)

BTW, the main things I think the library needs:

  1. tests
  2. make it non allocating, i.e. I am not convinced UVstreams should be classes with inheritance chain. I was hoping to turn them into simple struct handles.
  3. We need to make it multithreaded (somehow). There are many ideas for how it could work, none of the great.
  4. The APIs support sockets only. They should support other async concepts (like libuv): file i/o, timers, etc.

@ahsonkhan ahsonkhan added this to the Future milestone Apr 6, 2017
@ahsonkhan
Copy link
Member

We removed Libuv as part of #2244. Closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants