Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update .editorconfig to match file from coreclr #1195

Merged
ellismg merged 1 commit into from
Mar 21, 2015
Merged

Update .editorconfig to match file from coreclr #1195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,20 @@ root = true

# Default settings:
# A newline ending every file
# Use 2 spaces as indentation
# Trim trailing whitespace
# Use 4 spaces as indentation
[*]
insert_final_newline = true
Copy link
Copy Markdown

@sharwell sharwell Mar 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ This line should be removed IMO. It behaves "poorly" when used with certain designers and the project system and doesn't offer much.

Copy link
Copy Markdown
Contributor Author

@KindDragon KindDragon Mar 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux tools prefer final new line http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline

Copy link
Copy Markdown
Contributor

@ellismg ellismg Mar 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the place we are moving towards is to have the file have a final newline when it's human generated and just accept whatever tool generated files generate.

I don't have a strong preference either way, but Git and GitHub seem to prefer having the additional newline, so I'm fine with adding it when it doesn't require gymnastics.

indent_style = space
indent_size = 2
trim_trailing_whitespace = true

[*.cs]
indent_size = 4

[*.csproj]
# Xml project files
[*.{csproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}]
indent_size = 2

# Xml files
[*.{xml,stylecop,resx,ruleset}]
indent_size = 2

[*.nuspec]
# Xml config files
[*.{props,targets,config,nuspec}]
indent_size = 2