This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update .editorconfig to match file from coreclr#1195
Merged
ellismg merged 1 commit intodotnet:masterfrom Mar 21, 2015
Merged
Conversation
Contributor
|
LGTM |
There was a problem hiding this comment.
❗ This line should be removed IMO. It behaves "poorly" when used with certain designers and the project system and doesn't offer much.
Contributor
Author
There was a problem hiding this comment.
Linux tools prefer final new line http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline
Contributor
There was a problem hiding this comment.
I think the place we are moving towards is to have the file have a final newline when it's human generated and just accept whatever tool generated files generate.
I don't have a strong preference either way, but Git and GitHub seem to prefer having the additional newline, so I'm fine with adding it when it doesn't require gymnastics.
Contributor
|
LGTM. Thanks. |
ellismg
added a commit
that referenced
this pull request
Mar 21, 2015
Update .editorconfig to match file from coreclr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to match