This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Install binaries that are part of shared framework into separate folder #27841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we place all of our output binaries, whether or not they are part of the shared framework, into the same folder. As a result, we need to use our packaging projects to determine what goes into the shared framework. This requires core-setup to use the packages as a baseline for what files are included in the shared framework.
This PR changes our CMake scripts to place files that are in the shared framework not only in the Product folder, but also in a "sharedFramework" folder.
It also changes the
install_clrCMake function to take a DESTINATION parameter and be a little more readable at the usage locations.cc: @dotnet/coreclr-infra