Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@jkoritzinsky
Copy link
Member

Currently, we place all of our output binaries, whether or not they are part of the shared framework, into the same folder. As a result, we need to use our packaging projects to determine what goes into the shared framework. This requires core-setup to use the packages as a baseline for what files are included in the shared framework.

This PR changes our CMake scripts to place files that are in the shared framework not only in the Product folder, but also in a "sharedFramework" folder.

It also changes the install_clr CMake function to take a DESTINATION parameter and be a little more readable at the usage locations.

cc: @dotnet/coreclr-infra

…t easier to extend and easier to read.

Add additional install_clr commands to install the files that go into the shared framework into the sharedFramework folder.
… native version out of the native version header so in the case that the header doesn't exist we get something actionable.
@jkoritzinsky jkoritzinsky merged commit 03b7b31 into dotnet:master Nov 13, 2019
@jkoritzinsky jkoritzinsky deleted the cmake-install-sharedframework branch November 13, 2019 00:18
@janvorli
Copy link
Member

@jkoritzinsky this PR has broken RHEL 6 build, it has been failing consistently in CI since your change went it and I can repro it locally as well (it happens only with the -stripsymbols option passed to build.sh). Can you please look into it?
The error is as follows:

$<TARGET_FILE:System.Globalization.Native>.dbg
$<TARGET_FILE:System.Globalization.Native>.dbg
/usr/bin/objcopy:/root/coreclr/bin/obj/Linux.x64.Release/src/corefx/System.Globalization.Native/stvfieQR: cannot create debug link section `/root/coreclr/bin/obj/Linux.x64.Release/src/corefx/System.Globalization.Native/System.Globalization.Native.so.dbg': Invalid operation
gmake[2]: *** [src/corefx/System.Globalization.Native/System.Globalization.Native.so] Error 1
gmake[2]: *** Deleting file `src/corefx/System.Globalization.Native/System.Globalization.Native.so'
gmake[1]: *** [src/corefx/System.Globalization.Native/CMakeFiles/System.Globalization.Native.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs...

@jkoritzinsky
Copy link
Member Author

I’ll take a look as soon as I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants