This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update CoreCLR override to use the sharedFramework output folder instead of comparing with packages #8842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e shared-framework folder (no package needed).
dagood
reviewed
Nov 12, 2019
Member
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
Mainly style comments, but one about this maybe breaking arm64 building on arm64.
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
Member
|
Test failure may be this known flakiness: https://github.com/dotnet/core-setup/issues/8643 |
dagood
approved these changes
Nov 12, 2019
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
src/pkg/projects/netcoreapp/src/localnetcoreapp.override.targets
Outdated
Show resolved
Hide resolved
Member
Author
|
Failure is due to a lost connection in AzDO. Rerunning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the core-setup scripting to use a local CoreCLR build depends on the CoreCLR packages. With dotnet/coreclr#27841, we will be able to determine what files are part of the shared framework based on if they are in the sharedFramework folder.
This PR updates the CoreCLR override mechanism to use the sharedFramework folder instead of comparing files against the packages.