This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Msbuild 15.7.0-preview-000108 #8876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add feed to msbuild myget * Update MSBuild to 15.7.108 (contains both netcoreapp2.0 and netcoreapp2.1)
* Move some projects to netstandard2.0 * Use version agnostic $(TargetFrameworkIdentifier) property to make changing versions easier since we only care about .NET Framework vs .NET Standard * Add missing project to solution file * Update TestPackageProjects.targets to use netstandard2.0 on non-Windows
…explicit reference to netstandard 2.0 to TestFramework.
Collaborator
|
Looks like this is getting closer, thanks!. Also please move from 108 -> 120 :) |
Member
|
I think this will be broken on update to 120 until dotnet/msbuild#3126, sorry :( |
Member
|
(could do 108 as an intermediate if that's helpful) |
Author
|
@dotnet-bot Test Windows_NT x64 Release Build |
Member
|
@livarcocc can you update this to 122? It should be as easy as cherry-picking d87acca |
Member
|
The plot thickens: the node-reuse changes break this, as I suspected. But dotnet/msbuild#3052 also, independently, breaks it. I have NO IDEA HOW. That's why my attempts to build a simple escape hatch didn't work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #8855
@AndyGerlicher