This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Move some projects to netstandard2.0 #8692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use version agnostic $(TargetFrameworkIdentifier) property to make changing versions easier since we only care about .NET Framework vs .NET Standard * Add missing project to solution file
Collaborator
Author
|
There are a few projects that still target .NETStandard 1.5. I didn't need to update them to get MSBuild working so I didn't bother. Should I update those as well? |
Collaborator
Author
livarcocc
approved these changes
Feb 27, 2018
AndyGerlicher
approved these changes
Feb 27, 2018
nguerrera
reviewed
Mar 5, 2018
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net46' "> | ||
| <ItemGroup Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' "> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
livarcocc
pushed a commit
to livarcocc/cli-1
that referenced
this pull request
Mar 22, 2018
* Move some projects to netstandard2.0 * Use version agnostic $(TargetFrameworkIdentifier) property to make changing versions easier since we only care about .NET Framework vs .NET Standard * Add missing project to solution file * Update TestPackageProjects.targets to use netstandard2.0 on non-Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the changes I needed to make when inserting a new MSBuild that targets NETCoreApp2.1. I'll follow this up with an MSBuild insertion PR.