Skip to content

Attempt to fix strong-name signing #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Attempt to fix strong-name signing #227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313a9ac
Attempt to fix strong-name signing
sbomer Nov 19, 2024
599808f
Update eng/Signing.props to use the cecil.snk file
jtschuster Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@
<FileSignInfo Include="Mono.Cecil.Mdb.dll" CertificateName="3PartySHA2" />
<FileSignInfo Include="Mono.Cecil.Pdb.dll" CertificateName="3PartySHA2" />
</ItemGroup>
<ItemGroup>
<StrongNameSignInfo Include="CecilStrongName" PublicKeyToken="50cebf1cceb9d05e" CertificateName="3PartySHA2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works when you point to the .snk: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585148&view=results

The output from this build is valid when running sn /v Mono.Cecil.dll, and the previous builds failed validation.

Suggested change
<StrongNameSignInfo Include="CecilStrongName" PublicKeyToken="50cebf1cceb9d05e" CertificateName="3PartySHA2" />
<StrongNameSignInfo Include="$(MSBuildThisFileDirectory)..\cecil.snk" PublicKeyToken="50cebf1cceb9d05e" CertificateName="CecilStrongName" />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!

</ItemGroup>
</Project>