Attempt to fix strong-name signing #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
approved these changes
Nov 19, 2024
ViktorHofer
approved these changes
Nov 19, 2024
|
That didn't work - seems the |
|
Should the Include be the path to the .snk file? |
jtschuster
reviewed
Nov 19, 2024
eng/Signing.props
Outdated
| <FileSignInfo Include="Mono.Cecil.Pdb.dll" CertificateName="3PartySHA2" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <StrongNameSignInfo Include="CecilStrongName" PublicKeyToken="50cebf1cceb9d05e" CertificateName="3PartySHA2" /> |
There was a problem hiding this comment.
Looks like this works when you point to the .snk: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585148&view=results
The output from this build is valid when running sn /v Mono.Cecil.dll, and the previous builds failed validation.
Suggested change
| <StrongNameSignInfo Include="CecilStrongName" PublicKeyToken="50cebf1cceb9d05e" CertificateName="3PartySHA2" /> | |
| <StrongNameSignInfo Include="$(MSBuildThisFileDirectory)..\cecil.snk" PublicKeyToken="50cebf1cceb9d05e" CertificateName="CecilStrongName" /> |
There was a problem hiding this comment.
Thanks for figuring this out!
akoeplinger
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Attempt to fix strong-name signing * Update eng/Signing.props to use the cecil.snk file --------- Co-authored-by: Jackson Schuster <[email protected]> (cherry picked from commit 7f4a146)
akoeplinger
added a commit
that referenced
this pull request
Dec 18, 2024
This reverts commit 59f2ded. It got accidentally merged into 9.0 with dotnet/runtime#109297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cecil assemblies aren't being strong-name signed. Hoping this fixes it. Not sure if there's a good way to test this locally since we public-sign the assemblies during the build, then do final strong-name signing in MicroBuild, from what I understand.