Skip to content

[release/9.0] Move off of dead-lettered Windows preview helix queue #66219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 1 commit into from
Apr 8, 2026
Merged

[release/9.0] Move off of dead-lettered Windows preview helix queue #66219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/targets/Helix.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<HelixAvailableTargetQueue Include="Ubuntu.2204.Amd64.Open" Platform="Linux" />
<HelixAvailableTargetQueue Include="OSX.15.Amd64.Open" Platform="OSX" />
<HelixAvailableTargetQueue Include="Windows.11.Amd64.Client.Open" Platform="Windows" />
<HelixAvailableTargetQueue Include="Windows.Amd64.VS2022.Pre.Open" Platform="Windows" />
<HelixAvailableTargetQueue Include="Windows.Amd64.VS2022.Open" Platform="Windows" />
</ItemGroup>
</When>
<Otherwise>
Expand Down
6 changes: 3 additions & 3 deletions src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests;

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty split entry, which matches all Helix queues and skips this class unconditionally on Helix. Remove the trailing delimiter to scope the skip to Windows.Amd64.VS2022.Open as intended.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class Http2Tests : LoggedTest
{
private const string VersionForReset = "10.0.19529";
Expand Down Expand Up @@ -545,7 +545,7 @@ await h2Connection.ReceiveHeadersAsync(1, decodedHeaders =>
[ConditionalFact]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10, SkipReason = "Http2 requires Win10")]
[MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H1, SkipReason = "This is last version without custom Reset support")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/50916", Queues = "Windows.Amd64.VS2022.Pre")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/50916", Queues = "Windows.Amd64.VS2022")]
public async Task AppException_AfterHeaders_PriorOSVersions_ResetCancel()
{
using var server = Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
Expand Down Expand Up @@ -630,7 +630,7 @@ public async Task Reset_Http1_NotSupported()
[ConditionalFact]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10, SkipReason = "Http2 requires Win10")]
[MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H2, SkipReason = "This is last version without Reset support")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/50916", Queues = "Windows.Amd64.VS2022.Pre")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/50916", Queues = "Windows.Amd64.VS2022")]
public async Task Reset_PriorOSVersions_NotSupported()
{
using var server = Utilities.CreateDynamicHttpsServer(out var address, httpContext =>
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/AspNetCorePortTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. Because SkipOnHelixAttribute splits on ;, the empty entry matches every Helix queue, so this class is skipped on all Helix runs. Remove the trailing delimiter to avoid over-skipping.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class AspNetCorePortTests : IISFunctionalTestBase
{
// Port range allowed by ANCM config
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/BasicAuthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty queue entry and makes SkipOnHelix match all Helix queues, skipping unconditionally on Helix. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class BasicAuthTests : IISFunctionalTestBase
{
public BasicAuthTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/CompressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(IISCompressionSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. Splitting on ; yields an empty element which matches any Helix queue, so this class is skipped on every Helix run. Remove the trailing delimiter to avoid unintended global skipping.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class CompressionTests : FixtureLoggedTest
{
private readonly IISCompressionSiteFixture _fixture;
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues creates an empty queue entry and makes SkipOnHelix match every Helix queue (skipping unconditionally on Helix). Remove the trailing delimiter to scope the skip properly.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class FrebTests : IISFunctionalTestBase
{
public FrebTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/GlobalVersionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. After splitting, the empty entry matches all Helix queues and skips this class unconditionally on Helix. Remove the trailing delimiter.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class GlobalVersionTests : IISFunctionalTestBase
{
public GlobalVersionTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/Http2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
/// with newer functionality.
/// </summary>
[Collection(IISHttpsTestSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty entry after splitting and makes SkipOnHelix match all Helix queues, skipping unconditionally on Helix. Remove the trailing delimiter to avoid over-skipping.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class Http2Tests
{
public Http2Tests(IISTestSiteFixture fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/HttpsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[Collection(PublishedSitesCollection.Name)]
[SkipIfNotAdmin]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues yields an empty queue entry after splitting, which matches every Helix queue and skips unconditionally on Helix. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ClientCertificateTests : IISFunctionalTestBase
{
private readonly ClientCertificateFixture _certFixture;
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/Latin1Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. The empty entry created by splitting matches every Helix queue, so this class is skipped on all Helix runs. Remove the trailing delimiter to scope the skip properly.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class Latin1Tests : IISFunctionalTestBase
{
public Latin1Tests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/LoggingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues produces an empty queue entry and makes SkipOnHelix match every Helix queue, skipping unconditionally on Helix. Remove the trailing delimiter (or omit Queues to skip on all Helix queues explicitly).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class LoggingTests : IISFunctionalTestBase
{
public LoggingTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/MaxRequestBodySizeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty element after splitting, which matches all Helix queues and skips this class unconditionally on Helix. Remove the trailing delimiter.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class MaxRequestBodySizeTests : IISFunctionalTestBase
{
public MaxRequestBodySizeTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/MultiApplicationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;, which creates an empty queue entry and makes SkipOnHelix match every Helix queue (skipping unconditionally on Helix). Remove the trailing delimiter to avoid skipping on all Helix queues.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class MultiApplicationTests : IISFunctionalTestBase
{
private PublishedApplication _publishedApplication;
Expand Down
6 changes: 3 additions & 3 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestPathBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(IISSubAppSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concatenated Queues string ends up with a trailing ;, which introduces an empty entry after splitting and matches all Helix queues (skipping unconditionally on Helix). Remove the trailing delimiter and consider replacing the concatenation with a single literal.

Copilot uses AI. Check for mistakes.
public class RequestPathBaseTests : FixtureLoggedTest
{
private readonly IISSubAppSiteFixture _fixture;
Expand All @@ -32,7 +32,7 @@ public RequestPathBaseTests(IISSubAppSiteFixture fixture) : base(fixture)
}

[ConditionalTheory]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in the constructed Queues value results in an empty queue entry and causes SkipOnHelix to match all Helix queues. Remove the trailing delimiter to scope the skip to the intended queues.

Copilot uses AI. Check for mistakes.
[RequiresNewHandler]
[InlineData("/Sub/App/PathAndPathBase", "/Sub/App/PathAndPathBase", "")]
[InlineData("/SUb/APp/PathAndPAthBase", "/SUb/APp/PathAndPAthBase", "")]
Expand All @@ -53,7 +53,7 @@ public async Task RequestPathBase_Split(string url, string expectedPathBase, str
}

[ConditionalTheory]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in the constructed Queues value produces an empty element after splitting, which matches any Helix queue and skips unconditionally on Helix. Remove the trailing delimiter (or omit Queues if you want to skip all Helix queues).

Copilot uses AI. Check for mistakes.
[RequiresNewHandler]
[InlineData("//Sub/App/PathAndPathBase", "//Sub/App/PathAndPathBase", "")]
[InlineData(@"/\Sub/App/PathAndPathBase/", @"/\Sub/App/PathAndPathBase", "/")]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(IISTestSiteCollectionInProc.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues creates an empty split entry and makes SkipOnHelix match every Helix queue, skipping this test suite unconditionally on Helix. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is the intent).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class RequestResponseTests
{
private readonly IISTestSiteFixture _fixture;
Expand Down
4 changes: 2 additions & 2 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketInProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
[Collection(IISTestSiteCollectionInProc.Name)]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
#if IISEXPRESS_FUNCTIONALS
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]
#else
// These queues do not have websockets enabled currently for full IIS
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;Windows.Amd64.Server2022.Open")]
#endif
public class WebSocketsInProcessTests : WebSocketsTests
{
Expand Down
4 changes: 2 additions & 2 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketOutOfProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
[Collection(IISTestSiteCollectionOutOfProc.Name)]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
#if IISEXPRESS_FUNCTIONALS
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]
#else
// These queues do not have websockets enabled currently for full IIS
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;Windows.Amd64.Server2022.Open")]
#endif
public class WebSocketsOutOfProcessTests : WebSocketsTests
{
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/Common.FunctionalTests/WindowsAuthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. After splitting, the empty entry matches every Helix queue, so this class is skipped on all Helix runs. Remove the trailing delimiter to restrict the skip to the intended queue(s).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class WindowsAuthTests : IISFunctionalTestBase
{
public WindowsAuthTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
6 changes: 3 additions & 3 deletions src/Servers/IIS/IIS/test/Common.LongTests/ShutdownTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

// Contains all tests related to shutdown, including app_offline, abort, and app recycle
[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;, which creates an empty queue entry and makes SkipOnHelix match every Helix queue (skipping unconditionally on Helix). Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ShutdownTests : IISFunctionalTestBase
{
public ShutdownTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down Expand Up @@ -390,7 +390,7 @@ public async Task AppOfflineDropped_CanRemoveAppOfflineAfterAddingAndSiteWorks_O
}

[ConditionalFact]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues yields an empty entry after splitting, which matches all Helix queues and skips this test on any Helix run. Remove the trailing delimiter to avoid unintentionally skipping everywhere on Helix.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
[MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H2, SkipReason = "Shutdown hangs https://github.com/dotnet/aspnetcore/issues/25107")]
public async Task AppOfflineAddedAndRemovedStress_InProcess()
{
Expand Down Expand Up @@ -560,7 +560,7 @@ public async Task OutOfProcessToInProcessHostingModelSwitchWorks()
}

[ConditionalFact]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty queue entry; SkipOnHelix then matches any Helix queue and skips this test unconditionally on Helix. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public async Task ConfigurationTouchedStress_InProcess()
{
await ConfigurationTouchedStress(HostingModel.InProcess);
Expand Down
4 changes: 2 additions & 2 deletions src/Servers/IIS/IIS/test/Common.LongTests/StartupTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

// Contains all tests related to Startup, requiring starting ANCM/IIS every time.
[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Queues value is built from strings that end with ;, which produces a final trailing delimiter. SkipOnHelixAttribute splits on ;, and the resulting empty element matches all Helix queues, skipping this class on every Helix run. Remove the trailing delimiter (and consider using a single literal without +).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;Windows.Amd64.VS2022")]

Copilot uses AI. Check for mistakes.
public class StartupTests : IISFunctionalTestBase
{
public StartupTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down Expand Up @@ -1297,7 +1297,7 @@ public async Task PreferEnvironmentVariablesOverWebConfigWhenConfigured(HostingM
[ConditionalFact]
[RequiresNewHandler]
[RequiresNewShim]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty element after splitting, which matches all Helix queues and causes this class to be skipped unconditionally on Helix. Remove the trailing delimiter to scope the skip correctly.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;" + "Windows.Amd64.VS2022")]

Copilot uses AI. Check for mistakes.
public async Task ServerAddressesIncludesBaseAddress()
{
var appName = "\u041C\u043E\u0451\u041F\u0440\u0438\u043B\u043E\u0436\u0435\u043D\u0438\u0435";
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http2TrailersResetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
/// on IIS Express even on the new Windows versions because IIS Express has its own outdated copy of IIS.
/// </summary>
[Collection(IISHttpsTestSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. Because SkipOnHelixAttribute splits on ;, the empty element matches all Helix queues and makes this class always skipped on Helix. Remove the trailing delimiter to avoid unintentionally skipping on every Helix queue.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class Http2TrailerResetTests : FunctionalTestsBase
{
private const string WindowsVersionForTrailers = "10.0.20238";
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http3Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
[MsQuicSupported]
[HttpSysHttp3Supported]
[Collection(IISHttpsTestSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty entry; SkipOnHelix will match all Helix queues and skip these tests unconditionally on Helix. Remove the trailing delimiter (or omit Queues to skip on all Helix queues explicitly).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class Http3Tests : FunctionalTestsBase
{
public Http3Tests(IISTestSiteFixture fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.NewHandler.FunctionalTests/NewHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace Microsoft.AspNetCore.Server.IIS.NewHandler.FunctionalTests;

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. Splitting on ; yields an empty element that matches any queue, so this class is skipped on all Helix queues. Remove the trailing delimiter to scope the skip to the intended queue(s).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class NewHandlerTests : IISFunctionalTestBase
{
public NewHandlerTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/NewShimTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Microsoft.AspNetCore.Server.IIS.NewShim.FunctionalTests;

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues leads to an empty queue entry and makes SkipOnHelix match every Helix queue (skipping unconditionally on Helix). Remove the trailing delimiter (or omit Queues to skip on all Helix runs explicitly).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class NewShimTests : IISFunctionalTestBase
{
public NewShimTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.ShadowCopy.Tests/ShadowCopyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues has a trailing ;. After splitting on ;, the empty entry matches all Helix queues, so these tests are skipped on any Helix queue. Remove the trailing delimiter (or omit Queues if the intent is to skip on all Helix queues).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ShadowCopyTests : IISFunctionalTestBase
{
public ShadowCopyTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/ApplicationInitializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty element after splitting; SkipOnHelix then matches all Helix queues, skipping these tests unconditionally on Helix. Remove the trailing delimiter to restrict to the intended queue(s).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ApplicationInitializationTests : IISFunctionalTestBase
{
public ApplicationInitializationTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/StdOutRedirectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. SkipOnHelixAttribute splits on ;, and the empty entry matches all Helix queues, so this class is skipped on every Helix run. Remove the trailing delimiter (or omit Queues if the skip should apply to all Helix queues).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class StdOutRedirectionTests : IISFunctionalTestBase
{
public StdOutRedirectionTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues creates an empty entry after splitting, which matches every Helix queue and causes this class to be skipped on all Helix queues. Remove the trailing delimiter (or omit Queues if always skipping on Helix is intended).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ClientDisconnectTests : StrictTestServerTests
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/ConnectionIdFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. When SkipOnHelixAttribute splits the list, the empty element matches all Helix queues, skipping unconditionally on Helix. Remove the trailing delimiter to scope the skip properly.

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class ConnectionIdFeatureTests : StrictTestServerTests
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/HttpBodyControlFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues results in an empty element after splitting, which matches any Helix queue and skips this class unconditionally on Helix. Remove the trailing delimiter (or omit Queues to skip on all Helix queues explicitly).

Suggested change
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot uses AI. Check for mistakes.
public class HttpBodyControlFeatureTests : StrictTestServerTests
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/MaxRequestBodySizeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace IIS.Tests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues introduces an empty queue entry; SkipOnHelix then matches every Helix queue and skips these tests on any Helix run. Remove the trailing delimiter (or omit Queues if the intent is to skip on all Helix queues).

Copilot uses AI. Check for mistakes.
public class MaxRequestBodySizeTests : LoggedTest
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/ResponseAbortTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues produces an empty split entry and makes SkipOnHelix match all Helix queues, skipping unconditionally on Helix. Remove the trailing delimiter (or remove Queues to explicitly skip all Helix queues).

Copilot uses AI. Check for mistakes.
public class ResponseAbortTests : StrictTestServerTests
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/ResponseBodySizeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace IIS.Tests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues ends with a trailing ;. SkipOnHelixAttribute splits on ;, and the empty entry will match every Helix queue, effectively skipping on all Helix queues. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Copilot uses AI. Check for mistakes.
public class ResponseBodySizeTests : LoggedTest
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/TestServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues causes an empty element after splitting, which matches all Helix queues and makes these tests always skipped on Helix. Remove the trailing delimiter (or omit Queues to skip on all Helix queues intentionally).

Copilot uses AI. Check for mistakes.
public class TestServerTest : StrictTestServerTests
{
[ConditionalFact]
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/TlsHandshakeFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

[SkipIfHostableWebCoreNotAvailable]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "https://github.com/aspnet/IISIntegration/issues/866")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing ; in Queues creates an empty entry and makes SkipOnHelix match all Helix queues (so these tests are always skipped on Helix). Remove the trailing delimiter to scope the skip to the intended queue(s).

Copilot uses AI. Check for mistakes.
public class TlsHandshakeFeatureTests : StrictTestServerTests
{
[ConditionalFact]
Expand Down
Loading
Loading