[release/9.0] Move off of dead-lettered Windows preview helix queue by wtgodbe · Pull Request #66219 · dotnet/aspnetcore

wtgodbe · 2026-04-08T15:30:13Z

The preview queue is dead

Copilot

Pull request overview

This PR updates Helix queue references in Windows/IIS and HttpSys test projects (and Helix configuration) to move away from the dead-lettered Windows.Amd64.VS2022.Pre.Open / Windows.Amd64.VS2022.Pre queues and use the non-preview VS2022 queues instead.

Changes:

Replace Windows.Amd64.VS2022.Pre.Open with Windows.Amd64.VS2022.Open across multiple SkipOnHelix attributes in IIS-related tests.
Replace Windows.Amd64.VS2022.Pre with Windows.Amd64.VS2022 in HttpSys skip attributes for an existing issue.
Update eng/targets/Helix.Common.props to advertise Windows.Amd64.VS2022.Open as an available PR-check target queue.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 44 comments.

Show a summary per file

File	Description
src/Servers/IIS/IISIntegration/test/Tests/IISMiddlewareTests.cs	Updates Helix queue name in `SkipOnHelix` for IIS integration tests.
src/Servers/IIS/IISIntegration/test/Tests/IISExtensionTests.cs	Updates Helix queue name in `SkipOnHelix` for IIS integration extension tests.
src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/UpgradeFeatureDetectionTests.cs	Updates Helix queue name in `SkipOnHelix` for IIS Express functional tests.
src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/OutOfProcess/NtlmAuthentationTest.cs	Updates Helix queue name in `SkipOnHelix` for NTLM functional tests.
src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/OutOfProcess/MultipleAppTests.cs	Updates Helix queue name in `SkipOnHelix` for multi-app IIS Express tests.
src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/IISExpressShutdownTests.cs	Updates Helix queue name in `SkipOnHelix` for shutdown stress test.
src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/AppOfflineIISExpressTests.cs	Updates Helix queue name in `SkipOnHelix` for app_offline scenarios.
src/Servers/IIS/IIS/test/IIS.Tests/TlsHandshakeFeatureTests.cs	Updates Helix queue name in `SkipOnHelix` for TLS handshake tests.
src/Servers/IIS/IIS/test/IIS.Tests/TestServerTest.cs	Updates Helix queue name in `SkipOnHelix` for strict test server tests.
src/Servers/IIS/IIS/test/IIS.Tests/ResponseBodySizeTests.cs	Updates Helix queue name in `SkipOnHelix` for response body size tests.
src/Servers/IIS/IIS/test/IIS.Tests/ResponseAbortTests.cs	Updates Helix queue name in `SkipOnHelix` for response abort tests.
src/Servers/IIS/IIS/test/IIS.Tests/MaxRequestBodySizeTests.cs	Updates Helix queue name in `SkipOnHelix` for max request body size tests.
src/Servers/IIS/IIS/test/IIS.Tests/HttpBodyControlFeatureTests.cs	Updates Helix queue name in `SkipOnHelix` for body control feature tests.
src/Servers/IIS/IIS/test/IIS.Tests/ConnectionIdFeatureTests.cs	Updates Helix queue name in `SkipOnHelix` for connection-id tests.
src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs	Updates Helix queue name in `SkipOnHelix` for disconnect behavior tests.
src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/StdOutRedirectionTests.cs	Updates Helix queue name in `SkipOnHelix` for stdout redirection tests.
src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/ApplicationInitializationTests.cs	Updates Helix queue name in `SkipOnHelix` for app initialization tests.
src/Servers/IIS/IIS/test/IIS.ShadowCopy.Tests/ShadowCopyTests.cs	Updates Helix queue name in `SkipOnHelix` for shadow copy tests.
src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/NewShimTests.cs	Updates Helix queue name in `SkipOnHelix` for new shim tests.
src/Servers/IIS/IIS/test/IIS.NewHandler.FunctionalTests/NewHandlerTests.cs	Updates Helix queue name in `SkipOnHelix` for new handler tests.
src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http3Tests.cs	Updates Helix queue name in `SkipOnHelix` for HTTP/3 tests.
src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http2TrailersResetTests.cs	Updates Helix queue name in `SkipOnHelix` for HTTP/2 trailer/reset tests.
src/Servers/IIS/IIS/test/Common.LongTests/StartupTests.cs	Updates Helix queue names in `SkipOnHelix` for long-running startup scenarios.
src/Servers/IIS/IIS/test/Common.LongTests/ShutdownTests.cs	Updates Helix queue name in `SkipOnHelix` for long-running shutdown scenarios.
src/Servers/IIS/IIS/test/Common.FunctionalTests/WindowsAuthTests.cs	Updates Helix queue name in `SkipOnHelix` for Windows auth tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketOutOfProcessTests.cs	Updates Helix queue names in `SkipOnHelix` for out-of-proc WebSocket tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketInProcessTests.cs	Updates Helix queue names in `SkipOnHelix` for in-proc WebSocket tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs	Updates Helix queue name in `SkipOnHelix` for request/response tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestPathBaseTests.cs	Updates Helix queue names in `SkipOnHelix` for PathBase tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/MultiApplicationTests.cs	Updates Helix queue name in `SkipOnHelix` for multi-app functional tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/MaxRequestBodySizeTests.cs	Updates Helix queue name in `SkipOnHelix` for max-body-size functional tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/LoggingTests.cs	Updates Helix queue name in `SkipOnHelix` for logging tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/Latin1Tests.cs	Updates Helix queue name in `SkipOnHelix` for Latin1 behavior tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/HttpsTests.cs	Updates Helix queue name in `SkipOnHelix` for HTTPS/client-cert tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/Http2Tests.cs	Updates Helix queue name in `SkipOnHelix` for HTTP/2 functional tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/GlobalVersionTests.cs	Updates Helix queue name in `SkipOnHelix` for global version tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs	Updates Helix queue name in `SkipOnHelix` for FREB tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/CompressionTests.cs	Updates Helix queue name in `SkipOnHelix` for compression tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/BasicAuthTests.cs	Updates Helix queue name in `SkipOnHelix` for basic auth tests.
src/Servers/IIS/IIS/test/Common.FunctionalTests/AspNetCorePortTests.cs	Updates Helix queue name in `SkipOnHelix` for port tests.
src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs	Updates Helix queue names in `SkipOnHelix` for HttpSys HTTP/2 tests.
eng/targets/Helix.Common.props	Updates available Helix PR-check Windows queue from preview to `Windows.Amd64.VS2022.Open`.

Copilot · 2026-04-08T15:36:44Z

 namespace Microsoft.AspNetCore.Server.IISIntegration;

-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Queues ends with a trailing ;. SkipOnHelixAttribute splits on ;, and an empty entry will match every Helix queue (because every string starts with ""). This makes the test skip on all Helix queues rather than just Windows.Amd64.VS2022.Open. Remove the trailing delimiter (or omit Queues entirely if the intent is to skip on all Helix queues).

Copilot · 2026-04-08T15:36:44Z

 namespace Microsoft.AspNetCore.Server.IISIntegration;

-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Queues ends with a trailing ;. SkipOnHelixAttribute splits on ;, and an empty entry will match every Helix queue, so this effectively skips on all Helix queues. Remove the trailing delimiter (or omit Queues entirely to skip on all Helix queues explicitly).

Copilot · 2026-04-08T15:36:45Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Queues ends with a trailing ;. Because SkipOnHelixAttribute splits on ;, the empty element matches all queues and causes this test class to be skipped on all Helix queues. Remove the trailing ; (or remove Queues if the goal is to skip on any Helix run).

Copilot · 2026-04-08T15:36:45Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Trailing ; in Queues creates an empty queue entry; SkipOnHelixAttribute will then match every Helix queue and skip these tests unconditionally on Helix. Remove the trailing delimiter (or omit Queues to skip on all Helix queues intentionally).

Copilot · 2026-04-08T15:36:45Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Trailing ; in Queues results in an empty element after splitting, which matches all Helix queues and makes this class always skipped on Helix. Remove the trailing ; (or drop Queues if the intent is to always skip on Helix).

Copilot · 2026-04-08T15:36:56Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Trailing ; in Queues creates an empty queue entry and makes SkipOnHelix match every Helix queue (skipping unconditionally on Helix). Remove the trailing delimiter to scope the skip properly.

Suggested change

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot · 2026-04-08T15:36:56Z


 [Collection(IISCompressionSiteCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Queues ends with a trailing ;. Splitting on ; yields an empty element which matches any Helix queue, so this class is skipped on every Helix run. Remove the trailing delimiter to avoid unintended global skipping.

Suggested change

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot · 2026-04-08T15:36:56Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Trailing ; in Queues introduces an empty queue entry and makes SkipOnHelix match all Helix queues, skipping unconditionally on Helix. Remove the trailing delimiter (or omit Queues if skipping all Helix queues is intended).

Suggested change

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot · 2026-04-08T15:36:57Z


 [Collection(PublishedSitesCollection.Name)]
-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Queues ends with a trailing ;. Because SkipOnHelixAttribute splits on ;, the empty entry matches every Helix queue, so this class is skipped on all Helix runs. Remove the trailing delimiter to avoid over-skipping.

Suggested change

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Copilot · 2026-04-08T15:36:57Z

 namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests;

-[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
+[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]


Trailing ; in Queues introduces an empty split entry, which matches all Helix queues and skips this class unconditionally on Helix. Remove the trailing delimiter to scope the skip to Windows.Amd64.VS2022.Open as intended.

Suggested change

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Move off of dead-lettered Windows preview helix queue

f67deb3

wtgodbe requested review from BrennanConroy, JamesNK and halter73 as code owners April 8, 2026 15:30

Copilot AI review requested due to automatic review settings April 8, 2026 15:30

wtgodbe requested a review from a team as a code owner April 8, 2026 15:30

wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 8, 2026

Copilot started reviewing on behalf of wtgodbe April 8, 2026 15:31 View session

dotnet-policy-service Bot added this to the 9.0.x milestone Apr 8, 2026

Copilot AI reviewed Apr 8, 2026

View reviewed changes

github-actions Bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Apr 8, 2026

wtgodbe merged commit a334c60 into release/9.0 Apr 8, 2026
29 checks passed

wtgodbe deleted the wtgodbe/9Pre branch April 8, 2026 18:14

dotnet-policy-service Bot modified the milestones: 9.0.x, 9.0.16 Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/9.0] Move off of dead-lettered Windows preview helix queue#66219

[release/9.0] Move off of dead-lettered Windows preview helix queue#66219
wtgodbe merged 1 commit into
release/9.0from
wtgodbe/9Pre

wtgodbe commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open;")]
	[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Open")]

Conversation

wtgodbe commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants