Conversation
This fixes CFSClean errors.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates Maven repository configuration for the SignalR Java client by migrating from public repositories (Maven Central and Gradle Plugin Portal) to Microsoft's internal dnceng Azure DevOps feed. The change centralizes repository management in settings.gradle using modern Gradle best practices and is intended to resolve CFSClean (Component Governance) errors.
Key Changes:
- Centralized all repository declarations in
settings.gradleusingpluginManagementanddependencyResolutionManagement - Removed repository declarations from
build.gradlebuildscript and allprojects blocks - Configured
FAIL_ON_PROJECT_REPOSmode to enforce centralized repository management
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SignalR/clients/java/signalr/settings.gradle | Adds pluginManagement and dependencyResolutionManagement blocks with dnceng AzDO feed configuration, enforces centralized repository management |
| src/SignalR/clients/java/signalr/build.gradle | Removes buildscript repositories block and allprojects repositories block, relying on settings.gradle configuration |
Comments suppressed due to low confidence (1)
src/SignalR/clients/java/signalr/build.gradle:5
- The buildscript block declares a classpath dependency on spotless-plugin-gradle, but no repositories are configured for resolving this dependency. Buildscript dependencies are not resolved from the pluginManagement repositories in settings.gradle. You need to either add a repositories block within the buildscript block or convert this to use the plugins DSL instead. Consider replacing the buildscript approach with the plugins DSL by adding the plugin ID to the plugins block.
buildscript {
dependencies {
classpath "com.diffplug.spotless:spotless-plugin-gradle:6.6.1"
}
}
wtgodbe
approved these changes
Jan 7, 2026
Merged
Member
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Member
|
Components failure unrelated |
wtgodbe
added a commit
that referenced
this pull request
Jan 8, 2026
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe
added a commit
that referenced
this pull request
Jan 8, 2026
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe
added a commit
that referenced
this pull request
Jan 8, 2026
* Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe
added a commit
that referenced
this pull request
Jan 8, 2026
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com> --------- Co-authored-by: Brennan Conroy <brecon@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe
added a commit
that referenced
this pull request
Jan 9, 2026
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com> * Bump gson --------- Co-authored-by: Brennan Conroy <brecon@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe
added a commit
that referenced
this pull request
Jan 9, 2026
* Update gradle * update jdk * not specific ex * fixup * fixup * Use dnceng AzDO feed for maven (#64962) * Use dnceng AzDO feed for maven This fixes CFSClean errors. * Upgrade spotless-plugin-gradle to fix error with latest gradle --------- Co-authored-by: William Godbe <wigodbe@microsoft.com> * Bump gson * Update okhttp to 4.12 (#55434) --------- Co-authored-by: Brennan Conroy <brecon@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: Haidar <49842031+Haidar0096@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CFSClean errors.