Skip to content

Comments

Update build.gradle okhttp dependency #55434

Merged
BrennanConroy merged 1 commit intodotnet:mainfrom
Haidar0096:patch-1
Apr 30, 2024
Merged

Update build.gradle okhttp dependency #55434
BrennanConroy merged 1 commit intodotnet:mainfrom
Haidar0096:patch-1

Conversation

@Haidar0096
Copy link
Contributor

@Haidar0096 Haidar0096 commented Apr 30, 2024

Updated okhttp version to 4.12 because when using this library on android and building in release mode with the latest android gradle plugin, we get errors from the R8 shrinker saying that some classes are missing. here is the generated list from the R8 shrinker:

# Please add these rules to your existing keep rules in order to suppress warnings.
#-dontwarn org.bouncycastle.jsse.BCSSLParameters
#-dontwarn org.bouncycastle.jsse.BCSSLSocket
#-dontwarn org.bouncycastle.jsse.provider.BouncyCastleJsseProvider
#-dontwarn org.conscrypt.Conscrypt$Version
#-dontwarn org.conscrypt.Conscrypt
#-dontwarn org.conscrypt.ConscryptHostnameVerifier
#-dontwarn org.openjsse.javax.net.ssl.SSLParameters
#-dontwarn org.openjsse.javax.net.ssl.SSLSocket
#-dontwarn org.openjsse.net.ssl.OpenJSSE

Updating okhttp version

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

See above

Updated okhttp version to 4.12 because when using this library on android and building in release mode with the latest android gradle plugin, we get errors from the R8 shrinker saying that some classes are missing.
here is the generated list from the R8 shrinker:
```
# Please add these rules to your existing keep rules in order to suppress warnings.
#-dontwarn org.bouncycastle.jsse.BCSSLParameters
#-dontwarn org.bouncycastle.jsse.BCSSLSocket
#-dontwarn org.bouncycastle.jsse.provider.BouncyCastleJsseProvider
#-dontwarn org.conscrypt.Conscrypt$Version
#-dontwarn org.conscrypt.Conscrypt
#-dontwarn org.conscrypt.ConscryptHostnameVerifier
#-dontwarn org.openjsse.javax.net.ssl.SSLParameters
#-dontwarn org.openjsse.javax.net.ssl.SSLSocket
#-dontwarn org.openjsse.net.ssl.OpenJSSE
```
@ghost ghost added the area-signalr Includes: SignalR clients and servers label Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 30, 2024
@Haidar0096 Haidar0096 changed the title Update build.gradle Update build.gradle okhttp dependency Apr 30, 2024
@BrennanConroy BrennanConroy merged commit 923b62f into dotnet:main Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone Apr 30, 2024
@Haidar0096 Haidar0096 deleted the patch-1 branch April 30, 2024 18:59
wtgodbe pushed a commit that referenced this pull request Jan 8, 2026
wtgodbe added a commit that referenced this pull request Jan 9, 2026
* Update gradle

* update jdk

* not specific ex

* fixup

* fixup

* Use dnceng AzDO feed for maven (#64962)

* Use dnceng AzDO feed for maven

This fixes CFSClean errors.

* Upgrade spotless-plugin-gradle to fix error with latest gradle

---------

Co-authored-by: William Godbe <wigodbe@microsoft.com>

* Bump gson

* Update okhttp to 4.12 (#55434)

---------

Co-authored-by: Brennan Conroy <brecon@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: William Godbe <wigodbe@microsoft.com>
Co-authored-by: Haidar <49842031+Haidar0096@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants