Skip to content

Exclude more problematic assemblies from the ASP.NET composite #47812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Exclude more problematic assemblies from the ASP.NET composite #47812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,18 @@ This package is an internal implementation of the .NET Core SDK and is not meant

<ItemGroup>
<!-- Temporary workaround tracked by https://github.com/dotnet/runtime/issues/84860 -->
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Configuration.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Configuration.Abstractions.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Configuration.Binder.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.DependencyInjection.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.DependencyInjection.Abstractions.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Logging.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Logging.Abstractions.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Logging.Console.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Logging.Configuration.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Options.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Options.ConfigurationExtensions.dll" />
<ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Primitives.dll" />
Copy link
Member

@wtgodbe wtgodbe Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is growing quickly, how temporary do we think this workaround is? It could get hard to maintain

Copy link
Member Author

@trylek trylek Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We certainly hope to get this list removed ASAP, ideally in Preview 5, we just don't have enough time to address all the feedback on the tracking issue

dotnet/runtime#84860

before next Tuesday snap for Preview 4 we believe to be crucial for customer feedback as it corresponds to the Build conference.


<BaseAssemblies Include="$(ManagedAssetsFullPath)\*.dll" />
<BaseAssemblies Include="$(TargetDir)\*.dll" />
Expand Down
7 changes: 0 additions & 7 deletions src/Framework/App.Runtime/src/PartialCompositeAssemblyList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,9 @@ System.Private.CoreLib
System.Runtime
Microsoft.AspNetCore.Hosting
Microsoft.AspNetCore.Hosting.Abstractions
Microsoft.Extensions.Configuration.Abstractions
Microsoft.Extensions.DependencyInjection.Abstractions
Microsoft.Extensions.Configuration
Microsoft.EntityFrameworkCore
System.ComponentModel
Microsoft.AspNetCore.Server.Kestrel.Core
Microsoft.Extensions.Logging
Microsoft.Extensions.DependencyInjection
Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets
System.Console
System.Threading
Expand All @@ -20,7 +15,6 @@ Microsoft.Extensions.Configuration.Json
Microsoft.Extensions.Configuration.FileExtensions
Microsoft.Extensions.FileProviders.Abstractions
Microsoft.Extensions.FileProviders.Physical
Microsoft.Extensions.Primitives
Microsoft.Extensions.Configuration.EnvironmentVariables
Microsoft.Extensions.Configuration.CommandLine
System.Linq
Expand All @@ -36,7 +30,6 @@ Microsoft.AspNetCore.Http
System.Diagnostics.DiagnosticSource
Microsoft.AspNetCore.Mvc.Core
Microsoft.AspNetCore.Razor.Runtime
Microsoft.Extensions.Options
Microsoft.AspNetCore.Connections.Abstractions
System.Net.Primitives
Microsoft.AspNetCore.Hosting.Server.Abstractions
Expand Down