Exclude more problematic assemblies from the ASP.NET composite #47812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan has managed to identify the list of assemblies that cause problems in the dotnet app. I have rerun the perf measurements and, while there does seem to be impact (about 4 msecs), we still seem slightly faster than the default R2R publishing so I believe that excluding these assemblies from the ASP.NET composite image for now is the most expedient way to unblock the build of .NET composite Docker containers. Thanks Tomas
ghost
added
the
area-infrastructure
mangod9
approved these changes
Apr 20, 2023
wtgodbe
reviewed
Apr 20, 2023
| <ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Logging.Configuration.dll" /> | ||
| <ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Options.dll" /> | ||
| <ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Options.ConfigurationExtensions.dll" /> | ||
| <ExcludeAssemblies Include="$(TargetDir)\Microsoft.Extensions.Primitives.dll" /> |
Member
There was a problem hiding this comment.
This list is growing quickly, how temporary do we think this workaround is? It could get hard to maintain
Member
Author
There was a problem hiding this comment.
We certainly hope to get this list removed ASAP, ideally in Preview 5, we just don't have enough time to address all the feedback on the tracking issue
before next Tuesday snap for Preview 4 we believe to be crucial for customer feedback as it corresponds to the Build conference.
wtgodbe
approved these changes
Apr 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ivan has managed to identify the list of assemblies that cause problems in the dotnet app. I have rerun the perf measurements and, while there does seem to be impact (about 4 msecs increasing the plaintext benchmark startup time from 88 msecs to 92 msecs), we still seem slightly faster than the default R2R publishing (95 msecs) so I believe that excluding these assemblies from the ASP.NET composite image for now is the most expedient way to unblock the build of .NET composite Docker containers.
Thanks
Tomas
/cc @dotnet/crossgen-contrib