Skip to content

[release/7.0] [TS Client] Fix CompletionMessage result when passing false or null #45559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dougbu merged 1 commit into from
Jan 7, 2023
Merged

[release/7.0] [TS Client] Fix CompletionMessage result when passing false or null #45559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SignalR/clients/ts/signalr-protocol-msgpack/src/MessagePackHubProtocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ export class MessagePackHubProtocol implements IHubProtocol {
}

private _writeCompletion(completionMessage: CompletionMessage): ArrayBuffer {
const resultKind = completionMessage.error ? this._errorResult : completionMessage.result ? this._nonVoidResult : this._voidResult;
const resultKind = completionMessage.error ? this._errorResult :
(completionMessage.result !== undefined) ? this._nonVoidResult : this._voidResult;

let payload: any;
switch (resultKind) {
Expand Down
34 changes: 34 additions & 0 deletions src/SignalR/clients/ts/signalr-protocol-msgpack/tests/MessagePackHubProtocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,40 @@ describe("MessagePackHubProtocol", () => {
expect(new Uint8Array(buffer)).toEqual(payload);
});

it("can write completion message with false result", () => {
const payload = new Uint8Array([
0x09, // length prefix
0x95, // message array length = 5 (fixarray)
0x03, // type = 3 = Completion
0x80, // headers
0xa3, // invocationID = string length 3
0x61, // a
0x62, // b
0x63, // c
0x03, // result type, 3 - non-void result
0xc2, // false
]);
const buffer = new MessagePackHubProtocol().writeMessage({ type: MessageType.Completion, invocationId: "abc", result: false });
expect(new Uint8Array(buffer)).toEqual(payload);
});

it("can write completion message with null result", () => {
const payload = new Uint8Array([
0x09, // length prefix
0x95, // message array length = 5 (fixarray)
0x03, // type = 3 = Completion
0x80, // headers
0xa3, // invocationID = string length 3
0x61, // a
0x62, // b
0x63, // c
0x03, // result type, 3 - non-void result
0xc0, // null
]);
const buffer = new MessagePackHubProtocol().writeMessage({ type: MessageType.Completion, invocationId: "abc", result: null });
expect(new Uint8Array(buffer)).toEqual(payload);
});

it("will preserve double precision", () => {
const invocation = {
arguments: [Number(0.005)],
Expand Down