[release/7.0] [TS Client] Fix CompletionMessage result when passing false or null #45559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
BrennanConroy and
halter73
as code owners
ghost
added
the
BrennanConroy
requested review from
davidfowl and
halter73
and removed request for
halter73
BrennanConroy
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
halter73
approved these changes
Jan 4, 2023
BrennanConroy
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Member
|
Servicing approved over email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45169 to release/7.0
/cc @BrennanConroy
[TS Client] Fix CompletionMessage result when passing false or null
Description
Returning
falseor""or0would result in an unexpected exception on the server which the user would need to handle, instead it should give the value to the user code.Fixes #45168
Customer Impact
Customer reported issue. This has been a bug forever, but it hasn't surfaced until now because it's only likely to show up when sending
falsefrom the client side in a streaming method, which is very unusual. It's now a lot easier to return afalsevalue due to the "Client results" feature introduced in 7.0, so we should fix the problem in a 7.0 patch.Regression?
Risk
Small fix and well understood, just an oversight and missed test coverage which are now resolved.
Verification
Packaging changes reviewed?