Skip to content

!fixup! Correct CodeQL3000 setup #44809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dougbu merged 1 commit into from
Nov 1, 2022
Merged

!fixup! Correct CodeQL3000 setup #44809

dougbu merged 1 commit into from
Nov 1, 2022

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Oct 31, 2022

  • add tag only when CodeQL3000 tasks did useful work
    • ignore no-op task executions
  • correct tsaoptions.json location

@dougbu
!fixup! Correct CodeQL3000 setup
15046f2 
- add tag only when CodeQL3000 tasks did useful work
  - ignore no-op task executions
- correct tsaoptions.json location
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 31, 2022
@dougbu dougbu requested a review from garath October 31, 2022 21:20
@dougbu dougbu requested review from a team and wtgodbe as code owners October 31, 2022 21:20
@ghost
Copy link

ghost commented Oct 31, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Contributor Author

dougbu commented Nov 1, 2022

@HaoK @wtgodbe is it a bug that two build steps in the main Windows job are attempting to write to VS.Redist.Common.AspNetCore.AspNetCoreModuleV2.8.0.8.0.0-ci.nupkg❔ The ARM64 step is hitting file locking issues in CI validation. I think I've seen this before…

@dougbu dougbu merged commit 5ce916b into dotnet:main Nov 1, 2022
@dougbu dougbu deleted the dougbu/CodeQL3000/main.fixup branch November 1, 2022 02:33
@ghost ghost added this to the 8.0-preview1 milestone Nov 1, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Nov 1, 2022

@HaoK @wtgodbe is it a bug…

Passed on retry but may be a build flakiness issue.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 1, 2022

#44647 will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garath garath garath approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

3 participants

@dougbu @wtgodbe @garath