Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Oct 19, 2022

Realized while doing the VS insertion that the package doesn't have the architecture in the name, so only 1 package was getting produced & the other 2 architectures weren't getting their own package. Follow up to #39140

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2025267&view=results

@wtgodbe wtgodbe requested a review from a team October 19, 2022 20:36
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 19, 2022
@wtgodbe
Copy link
Member Author

wtgodbe commented Oct 19, 2022

Will backport to 6/7 once I validate this works

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this require another change elsewhere to react to the new names❔

@wtgodbe
Copy link
Member Author

wtgodbe commented Oct 19, 2022

Will this require another change elsewhere to react to the new names❔

No, they're not depended upon by any other repo, and I haven't done the VS insertion yet

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 2, 2022

/backport to release/7.0

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 2, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

@wtgodbe wtgodbe merged commit 0f51760 into dotnet:main Nov 2, 2022
@wtgodbe wtgodbe deleted the wtgodbe/FixANCMPack branch November 2, 2022 16:53
@ghost ghost added this to the 8.0-preview1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants