Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MvcCoreLoggerExtensions to use LoggerMessageAttribute #40439

Merged
merged 1 commit into from
Mar 1, 2022

Commits on Feb 27, 2022

  1. Update MvcCoreLoggerExtensions to use LoggerMessageAttribute

    MvcCoreLoggerExtensions includes the log messages for a whole slew of MVC types. Consequently
    it re-uses event ids and is hard maintain. This PR simultaenously updates the type to use
    LoggerMessageAttribute, while also attempts to move as many of the individual log statements to the
    appropriate type.
    
    This change unearthed incorrect reuse of event ids within the same type that has also been corrected by assigning
    new ids.
    
    Fixes dotnet#32087
    pranavkm committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    f69b2d7 View commit details
    Browse the repository at this point in the history