Remove usage of the Microsoft.NETCore.Internal package and replace with other non-shipping packages from dotnet/runtime to get a non-shipping version. #27737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th other non-shipping packages from dotnet/runtime to get a non-shipping version.
mmitche
reviewed
Nov 11, 2020
dougbu
reviewed
Nov 11, 2020
Contributor
|
Adding @dotnet/aspnet-build for awareness. |
wtgodbe
approved these changes
Nov 11, 2020
mkArtakMSFT
added
the
area-infrastructure
Member
Author
|
@dougbu can you triage the failing tests for me? I don't know enough about the aspnetcore repo. |
Contributor
|
@jkoritzinsky I didn't look at all failures but the only problems I saw were instances of https://github.com/dotnet/core-eng/issues/11391. I told AzDO to rerun the failed jobs. |
dougbu
reviewed
Nov 16, 2020
src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj
Outdated
Show resolved
Hide resolved
- adjust version properties to align with 44c0e66 / dotnet#27784
JunTaoLuo
approved these changes
Nov 16, 2020
Contributor
|
Latest failures are more of dotnet/runtime#44700. Good news is flaky AzDO feeds didn't break all of the jobs I retried last time. May slowly get to success. |
Contributor
|
Thanks very much @jkoritzinsky❕ |
This was referenced Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Microsoft.NETCore.App package is being removed in dotnet/runtime#38457. The usage in ASP.NET Core can be replaced with the .NET Core Shared Framework VS insertion package and the Browser Debug Host transport package, which have the nonshipping version number that matches a runtime build.