Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 13, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 2ccac658-6e68-4e98-ebd5-08d85e711a64
  • Build: 20201116.8
  • Date Produced: 11/16/2020 11:42 PM
  • Commit: bed28f348ccd4bffbac619eb5c55c98836a3ef4b
  • Branch: refs/heads/release/5.0

From https://github.com/dotnet/efcore

  • Subscription: 5a5466f0-17ae-442c-2f05-08d85e5f2673
  • Build: 20201114.1
  • Date Produced: 11/15/2020 6:47 AM
  • Commit: d05f81d011fbe4f22cce0a904590b194e588fbe3
  • Branch: refs/heads/release/5.0

…1113.5

System.ComponentModel.Annotations , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Cryptography.Cng , System.Runtime.CompilerServices.Unsafe , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.IO.Pipelines
 From Version 5.0.0 -> To Version 5.0.0
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner November 13, 2020 19:20
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Nov 13, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 13, 2020
…113.7

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer
 From Version 5.0.1 -> To Version 5.0.1
@dotnet-maestro dotnet-maestro bot changed the title [release/5.0] Update dependencies from dotnet/runtime [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore Nov 13, 2020
@JunTaoLuo
Copy link
Contributor

Failed Microsoft.AspNetCore.SharedFxTests.SharedFrameworkContainsExpectedFiles [2 ms]
  Error Message:
   Assert.Empty() Failure
Collection: ["System.Formats.Asn1", "Microsoft.Win32.Registry", "System.Security.Cryptography.Cng", "System.Security.Principal.Windows"]

There are unexpected dlls in our shared framework. Looking into why. For example System.Formats.Asn1.dll is something that's in Microsoft.NETCore.App and should not be in Microsoft.AspNetCore.App.

…1113.12

System.ComponentModel.Annotations , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Cryptography.Cng , System.Runtime.CompilerServices.Unsafe , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.Drawing.Common , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.IO.Pipelines
 From Version 5.0.0 -> To Version 5.0.0
@dotnet-maestro dotnet-maestro bot changed the title [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime Nov 14, 2020
…114.1

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer
 From Version 5.0.1 -> To Version 5.0.1
@dotnet-maestro dotnet-maestro bot changed the title [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore Nov 15, 2020
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche do we still need to move Pinned <Dependency /> elements to the bottom of <ProductDependencies />

- dotnet/runtime is not currently producing a useful Microsoft.Extensions.Internal.Transport
- quickest way to ignore the bad stuff is to pin the package here
dougbu and others added 2 commits November 16, 2020 15:17
…1116.8

Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport
 From Version 5.0.0-rtm.20519.4 -> To Version 5.0.1-servicing.20566.8
@dotnet-maestro dotnet-maestro bot changed the title [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime Nov 17, 2020
@dotnet-maestro dotnet-maestro bot merged commit becdf3b into release/5.0 Nov 17, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/5.0-16c5d51d-36a2-4714-994a-23e32732e699 branch November 17, 2020 02:17
<Sha>bfc49945c0bedeffe01bb5d6f3c217dad207d0d8</Sha>
</Dependency>
<Dependency Name="Microsoft.Extensions.HostFactoryResolver.Sources" Version="5.0.0-rtm.20519.4">
<Dependency Name="Microsoft.Extensions.HostFactoryResolver.Sources" Version="5.0.0-rtm.20563.12">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anipik @ericstj this looks Just Wrong:tm: Why didn't the package move to 5.0.1-servicing.20566.8

@mmitche another possibility is this might be yet-another remnant of the extra dotnet/runtime builds (like most of the 5.0.0 SHA updates in this file). Will those SHAs and this version be fixed in the first dependency PR after you clear things out❔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping @mmitche will fix this in #27915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants