Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all .xml files in targeting pack #26147

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 21, 2020

Resolve the 5.0 part of #26073. We were intentionally including the .xml files for project references & Extensions references, but not other package references.

@Pilchie is this OK for GA tell-mode?

@wtgodbe wtgodbe requested review from dagood and a team September 21, 2020 20:55
@ghost ghost added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Sep 21, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 21, 2020

Yes, I'm happy with that.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 21, 2020
@dougbu
Copy link
Member

dougbu commented Sep 21, 2020

Please retarget to release/5.0-rc2

@wtgodbe wtgodbe changed the base branch from release/5.0 to release/5.0-rc2 September 21, 2020 21:50
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 21, 2020

Please retarget to release/5.0-rc2

Done. @Pilchie fine for rc2 tell mode?

@Pilchie
Copy link
Member

Pilchie commented Sep 21, 2020

Yes.

@wtgodbe wtgodbe merged commit c34d1dc into release/5.0-rc2 Sep 22, 2020
@wtgodbe wtgodbe deleted the wtgodbe/xml50 branch September 22, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants