-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all .xml files in targeting pack #26147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
feature-platform
Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
label
Sep 21, 2020
Yes, I'm happy with that. |
wtgodbe
added
the
tell-mode
Indicates a PR which is being merged during tell-mode
label
Sep 21, 2020
Please retarget to release/5.0-rc2 |
dagood
approved these changes
Sep 21, 2020
dougbu
reviewed
Sep 21, 2020
Done. @Pilchie fine for rc2 tell mode? |
Yes. |
dougbu
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature-platform
Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
tell-mode
Indicates a PR which is being merged during tell-mode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the 5.0 part of #26073. We were intentionally including the .xml files for project references & Extensions references, but not other package references.
@Pilchie is this OK for GA tell-mode?