-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing xml documentation for targeting packs #26073
Comments
This belongs in dotnet/runtime--I confirmed |
Tagging subscribers to this area: @buyaa-n, @krwq, @jeffhandley |
cc @Pilchie This might be something we want to do for RTM |
@BrennanConroy are you sure about aspnet vs runtime? Preview 7 (your screenshot) says this is in AspNetCore.App, but in RC1, this is in NETCore.App. Did it move again after RC1? |
Yes, it moved back to AspNetCore.App after RC1. @dotnet/aspnet-build can someone take a look? |
@ericstj should number 3 be |
This appears to be a regression from 3.1 in the case of System.IO.Pipelines. In 3.1 we included (and should include) reference XML next to reference assembly. Are you seeing the same for all packages, or just Pipelines? I checked System.Diagnositcs.EventLog and Registry and they looked OK to me. I opened a bug to track the Pipelines issue: dotnet/runtime#42479 I think you should be fine to pull the XML from the nuget package for the others, and we should fix this for pipelines. |
I filed #26068 about this for 3.1.8, it seems like a bug. We also saw it in 3.1.3 but didn't quite report it here in aspnetcore at the time. |
@ericstj I didn't check the other packages. Thanks. So, System.IO.Pipelines is a separate case that'll require a dotnet/runtime fix to enable the scenario to be patched up. The larger issue is: We never had the correct |
@Pilchie I'm not going to get to this 'til Monday and doubt other @dotnet/aspnet-build members are hankering for a weekend project. That puts this into 3.1.10 and 5.0 RTM. Am I correct bot fixes should meet the bar given the missing documentation files worsen the ASP.NET Core development experience in every IDE on every platform❔ |
Looking at this today |
Yes |
The targeting packs in .NET 5 include the assemblies (
.dll
files) and documentation (.xml
) files. For example, theMicrosoft.NETCore.App.Ref
targeting pack includesSystem.Collections.dll
as well asSystem.Collections.xml
(the documentation).But this information is missing for some packages, such as
System.IO.Pipelines
Originally reported at dotnet/source-build#1686
The text was updated successfully, but these errors were encountered: