Cache _absoluteRequestTarget when reusing strings #18547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
halter73
added
Servicing-consider
leecow
added
Servicing-approved
Contributor
|
Need a review to merge @Tratcher @jkotalik @davidfowl |
jkotalik
approved these changes
Feb 14, 2020
Contributor
|
Thanks! |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release/3.1 backport of #18529
I think this is worth patching, because this is a regression introduced in 3.0 where a sequence of valid HTTP/1.x requests causes a NullReferenceException in Kestrel which stops request processing and aborts the underlying connection. You can work around the issue by setting
KestrelServerOptions.DisableStringReuseto true, but that causes a perf hit.Fixes #18438