Cache _absoluteRequestTarget when reusing strings #18529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
Tratcher,
analogrelay and
jkotalik
as code owners
ghost
added
the
Contributor
|
Can you open the PR to 3.1? |
jkotalik
approved these changes
Jan 23, 2020
halter73
force-pushed
the
halter73/18438
branch
from
992fcfb to
6a79431
Compare
benaadams
approved these changes
Jan 23, 2020
davidfowl
approved these changes
Jan 23, 2020
Member
davidfowl
left a comment
davidfowl
left a comment
There was a problem hiding this comment.
Nice find! Feels like we should patch this
halter73
force-pushed
the
halter73/18438
branch
from
6a79431 to
a8e233f
Compare
Contributor
|
@halter73 can you merge this? |
|
Hello @halter73! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
Do we still need this? We merged this change in to 3.1, so it should flow forward, right? |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a NullReferenceException when two identical absolute form targets are received in a row on the same connection and
KestrelServerOptions.DisableStringReuseis false (which is the default). See test for example.This was introduced in 3.0. I think we will want to backport this fix to 3.1 since it's LTS.
Addresses #18438
@benaadams