Fix Azure ServiceBus sku when using private endpoints#14484
Merged
eerhardt merged 1 commit intodotnet:release/13.2from Feb 13, 2026
Merged
Fix Azure ServiceBus sku when using private endpoints#14484eerhardt merged 1 commit intodotnet:release/13.2from
eerhardt merged 1 commit intodotnet:release/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14484Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14484" |
This was referenced Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in Azure Service Bus resource provisioning where the Standard SKU was being used when private endpoints were configured. Azure Service Bus Standard SKU does not support private endpoints and requires the Premium SKU.
Changes:
- Modified the SKU selection logic to conditionally use "Premium" when private endpoints are configured, otherwise "Standard"
- Updated the corresponding test snapshot to expect "Premium" SKU in the generated Bicep file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs | Added conditional logic to set SKU to "Premium" when hasPrivateEndpoint is true, otherwise "Standard" |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzurePrivateEndpointLockdownTests.AddAzureServiceBus_WithPrivateEndpoint_GeneratesCorrectBicep.verified.bicep | Updated test snapshot to verify the SKU parameter is set to "Premium" when private endpoints are configured |
sebastienros
approved these changes
Feb 13, 2026
Member
|
|
Member
Author
Ooops! |
Standard SKU doesn't work with private endpoints. It needs to be Premium.
eerhardt
force-pushed
the
FixPrivateEndpoints
branch
from
fea376e to
f5e2ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard SKU doesn't work with private endpoints. It needs to be Premium.
Checklist
Add docs for Azure Virtual Networks, Subnets, and Private Endpoints microsoft/aspire.dev#376