- 
                Notifications
    You must be signed in to change notification settings 
- Fork 715
Improve AI models enum #12107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Improve AI models enum #12107
Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            5 changes: 5 additions & 0 deletions
          
          5 
        
  src/Aspire.Hosting.Azure.AIFoundry/build/Aspire.Hosting.Azure.AIFoundry.props
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <Project> | ||
| <ItemGroup> | ||
| <Using Include="Aspire.Hosting.Azure.AIFoundryModel" Alias="AIFoundryModel" /> | ||
| </ItemGroup> | ||
| </Project> | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|  | ||
| namespace Aspire.Hosting.GitHub; | ||
|  | ||
| // This file contains obsolete elements kept for backward compatibility. | ||
|  | ||
| public partial class GitHubModel | ||
| { | ||
| public static partial class Core42 | ||
| { | ||
| /// <inheritdoc cref="Jais30bChat"/> | ||
| [Obsolete("Use Jais30bChat instead.")] | ||
| public static readonly GitHubModel JAIS30bChat = new() { Id = "core42/jais-30b-chat" }; | ||
| } | ||
|  | ||
| public static partial class Microsoft | ||
| { | ||
| /// <inheritdoc cref="MaiDSR1"/> | ||
| [Obsolete("Use MaiDSR1 instead.")] | ||
| public static readonly GitHubModel MAIDSR1 = new() { Id = "microsoft/mai-ds-r1" }; | ||
| } | ||
|  | ||
| public static partial class OpenAI | ||
| { | ||
| /// <inheritdoc cref="OpenAIGpt41"/> | ||
| [Obsolete("Use OpenAIGpt41 instead.")] | ||
| public static readonly GitHubModel OpenAIGPT41 = new() { Id = "openai/gpt-4.1" }; | ||
|  | ||
| /// <inheritdoc cref="OpenAIGpt41Mini"/> | ||
| [Obsolete("Use OpenAIGpt41Mini instead.")] | ||
| public static readonly GitHubModel OpenAIGPT41Mini = new() { Id = "openai/gpt-4.1-mini" }; | ||
|  | ||
| /// <inheritdoc cref="OpenAIGpt41Nano"/> | ||
| [Obsolete("Use OpenAIGpt41Nano instead.")] | ||
| public static readonly GitHubModel OpenAIGPT41Nano = new() { Id = "openai/gpt-4.1-nano" }; | ||
|  | ||
| /// <inheritdoc cref="OpenAIGpt4o"/> | ||
| [Obsolete("Use OpenAIGpt4o instead.")] | ||
| public static readonly GitHubModel OpenAIGPT4o = new() { Id = "openai/gpt-4o" }; | ||
|  | ||
| /// <inheritdoc cref="OpenAIGpt4oMini"/> | ||
| [Obsolete("Use OpenAIGpt4oMini instead.")] | ||
| public static readonly GitHubModel OpenAIGPT4oMini = new() { Id = "openai/gpt-4o-mini" }; | ||
| } | ||
| } | ||
        
          
          
            5 changes: 5 additions & 0 deletions
          
          5 
        
  src/Aspire.Hosting.GitHub.Models/build/Aspire.Hosting.GitHub.Models.props
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <Project> | ||
| <ItemGroup> | ||
| <Using Include="Aspire.Hosting.GitHub.GitHubModel" Alias="GitHubModel" /> | ||
| </ItemGroup> | ||
| </Project> | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
[EditorBrowsable(EditorBrowsableState.Never)]to these fields?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, will also do it for foundry.