Improve AI models enum #12107
Merged
Improve AI models enum #12107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12107Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12107" |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the GitHub Models and AI Foundry enumerations by refactoring the generation logic to produce consistent PascalCase method names and adding implicit usings for better developer experience.
Key Changes:
- Updated the GitHubModel enumeration generator to use consistent PascalCase naming conventions
- Added implicit usings for both GitHub Models and AI Foundry models
- Refactored obsolete model references to use new naming conventions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.GitHub.Models/tools/GenModel.cs | Replaces ToId method with ToPascalCase using regex patterns for better naming consistency |
| src/Aspire.Hosting.GitHub.Models/build/Aspire.Hosting.GitHub.Models.props | Adds implicit using for GitHubModel with alias |
| src/Aspire.Hosting.GitHub.Models/GitHubModel.Obsolete.cs | Creates obsolete wrapper properties for backward compatibility |
| src/Aspire.Hosting.GitHub.Models/GitHubModel.Generated.cs | Updates generated code with new PascalCase naming and partial classes |
| src/Aspire.Hosting.Azure.AIFoundry/build/Aspire.Hosting.Azure.AIFoundry.props | Adds implicit using for AIFoundryModel with alias |
| playground/GitHubModelsEndToEnd/GitHubModelsEndToEnd.AppHost/Program.cs | Updates reference to use new PascalCase property name |
| playground/AzureAIFoundryEndToEnd/AzureAIFoundryEndToEnd.AppHost/Program.cs | Removes unused variable declaration |
JamesNK
approved these changes
Oct 17, 2025
| { | ||
| /// <inheritdoc cref="Jais30bChat"/> | ||
| [Obsolete("Use Jais30bChat instead.")] | ||
| public static readonly GitHubModel JAIS30bChat = new() { Id = "core42/jais-30b-chat" }; |
There was a problem hiding this comment.
Add [EditorBrowsable(EditorBrowsableState.Never)] to these fields?
There was a problem hiding this comment.
Good idea, will also do it for foundry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11742
Checklist
<remarks />and<code />elements on your triple slash comments?