Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public static GenAIVisualizerDialogViewModel Create(
viewModel.InputMessages = viewModel.Items.Where(e => e.Type is GenAIItemType.SystemMessage or GenAIItemType.UserMessage or GenAIItemType.AssistantMessage or GenAIItemType.ToolMessage).ToList();
viewModel.OutputMessages = viewModel.Items.Where(e => e.Type == GenAIItemType.OutputMessage).ToList();

viewModel.NoMessageContent = AllMessagesHaveNoContent(viewModel.InputMessages) && AllMessagesHaveNoContent(viewModel.OutputMessages);
viewModel.NoMessageContent = AllMessagesHaveNoContent(viewModel.InputMessages) && AllMessagesHaveNoContent(viewModel.OutputMessages) && viewModel.ErrorItem == null;

return viewModel;
}
Expand All @@ -100,7 +100,8 @@ private static bool AllMessagesHaveNoContent(List<GenAIItemViewModel> messageVie
{
if (messageViewModels.Count == 0)
{
return false;
// Microsoft.Extensions.AI doesn't output any message telemetry when sensitive data isn't enabled.
return true;
}

foreach (var messageViewModel in messageViewModels)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,50 @@ public void Create_GenAISpanAttributesWithoutContent_HasNoMessageContent()
Assert.True(vm.NoMessageContent);
}

[Fact]
public void Create_NoMessages_HasNoMessageContent()
{
// Arrange
var repository = CreateRepository();

var attributes = new KeyValuePair<string, string>[]
{
KeyValuePair.Create(GenAIHelpers.GenAISystem, "System!"),
KeyValuePair.Create("server.address", "ai-server.address"),
};

var addContext = new AddContext();
repository.AddTraces(addContext, new RepeatedField<ResourceSpans>()
{
new ResourceSpans
{
Resource = CreateResource(),
ScopeSpans =
{
new ScopeSpans
{
Scope = CreateScope(),
Spans =
{
CreateSpan(traceId: "1", spanId: "1-1", startTime: s_testTime.AddMinutes(1), endTime: s_testTime.AddMinutes(10), attributes: attributes)
}
}
}
}
});
Assert.Equal(0, addContext.FailureCount);

var span = repository.GetSpan(GetHexId("1"), GetHexId("1-1"))!;
var spanDetailsViewModel = SpanDetailsViewModel.Create(span, repository, repository.GetResources());

// Act
var vm = Create(repository, spanDetailsViewModel);

// Assert
Assert.Empty(vm.Items);
Assert.True(vm.NoMessageContent);
}

private static GenAIVisualizerDialogViewModel Create(
TelemetryRepository repository,
SpanDetailsViewModel spanDetailsViewModel)
Expand Down
Loading