-
Notifications
You must be signed in to change notification settings - Fork 704
[release/9.5] Display help text for GenAI sensitive data when no messages #11668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11668 Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11668" |
Completing new feature, low risk, approved for 9.5.1 |
davidfowl
approved these changes
Sep 27, 2025
adamint
approved these changes
Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11656 to release/9.5
/cc @JamesNK
Customer Impact
MEAI changed how it writes telemetry in the latest version. If sensitive data isn't enabled then MEAI telemetry doesn't output any messages. Unfortunatly the help text only displays if there are messages with no content, but not when there are no messages at all.
Users can be left confused about why the GenAI telemetry visualizer in the dashboard doesn't show them detailed informaiton.
PR changes that logic to display help text when there are no messages:
Testing
Manual and unit testing
Risk
Low
Regression?
No