-
Notifications
You must be signed in to change notification settings - Fork 736
[release/9.4] Backport of 10422 #10555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports missing changes from PR #10422 to the release/9.4 branch to fix build breaks caused by restructuring of the aspire exec command testing infrastructure. The changes include API method renames, improved interaction handling, and expanded testing capabilities.
Key Changes
- Method renames: Azure storage and data services methods renamed from
AddAzure*ClienttoAddAzure*ServiceClientpatterns - Test infrastructure updates: Enhanced interaction testing, removed E2E exec tests, added new console interaction tests
- Component API improvements: Added new queue client support, parameter handling enhancements, and container build options
Reviewed Changes
Copilot reviewed 293 out of 336 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Aspire.Hosting.Azure.Tests/AzureResourcePreparerTests.cs |
Updated method calls from AddBlobs to AddBlobService |
tests/Aspire.Hosting.Azure.Tests/AzureKeyVaultTests.cs |
Added test for KV secret resource manifest exclusion |
tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs |
Enhanced peer resolution with connection string and parameter support |
tests/Aspire.Cli.Tests/E2E/ExecTests.cs |
Removed entire E2E exec test file |
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs |
Added new queue service client methods and obsoleted old ones |
src/Aspire.Hosting/VersionChecking/VersionCheckService.cs |
Replaced version fetcher with package fetcher for better update checking |
Files not reviewed (5)
- src/Aspire.Cli/Resources/AddCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/TemplatingStrings.Designer.cs: Language not supported
- src/Aspire.Dashboard/Resources/ConsoleLogs.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs:220
- [nitpick] The method name
TryResolvePeerCoresuggests this is an internal implementation detail. Consider if this should be calledTryResolvePeerNameCoreto match the original method name pattern.
return ResourceOutgoingPeerResolver.TryResolvePeerCore(resources, attributes, out peerName, out _);
This PR is a backport of a missing PR to main that caused some build breaks on the release/9.4 branch because of some restructuring of the way that the
aspire execcommand was tested.See #10422 for details of the original PR.