Skip to content

Conversation

@mitchdenny
Copy link
Member

This PR is a backport of a missing PR to main that caused some build breaks on the release/9.4 branch because of some restructuring of the way that the aspire exec command was tested.

See #10422 for details of the original PR.

Copilot AI review requested due to automatic review settings July 19, 2025 07:29
@mitchdenny mitchdenny changed the base branch from main to release/9.4 July 19, 2025 07:29
@mitchdenny mitchdenny requested a review from DeagleGross July 19, 2025 07:30
@mitchdenny mitchdenny self-assigned this Jul 19, 2025
@mitchdenny mitchdenny added this to the 9.4 milestone Jul 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports missing changes from PR #10422 to the release/9.4 branch to fix build breaks caused by restructuring of the aspire exec command testing infrastructure. The changes include API method renames, improved interaction handling, and expanded testing capabilities.

Key Changes

  • Method renames: Azure storage and data services methods renamed from AddAzure*Client to AddAzure*ServiceClient patterns
  • Test infrastructure updates: Enhanced interaction testing, removed E2E exec tests, added new console interaction tests
  • Component API improvements: Added new queue client support, parameter handling enhancements, and container build options

Reviewed Changes

Copilot reviewed 293 out of 336 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/Aspire.Hosting.Azure.Tests/AzureResourcePreparerTests.cs Updated method calls from AddBlobs to AddBlobService
tests/Aspire.Hosting.Azure.Tests/AzureKeyVaultTests.cs Added test for KV secret resource manifest exclusion
tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs Enhanced peer resolution with connection string and parameter support
tests/Aspire.Cli.Tests/E2E/ExecTests.cs Removed entire E2E exec test file
src/Components/Aspire.Azure.Storage.Queues/AspireQueueStorageExtensions.cs Added new queue service client methods and obsoleted old ones
src/Aspire.Hosting/VersionChecking/VersionCheckService.cs Replaced version fetcher with package fetcher for better update checking
Files not reviewed (5)
  • src/Aspire.Cli/Resources/AddCommandStrings.Designer.cs: Language not supported
  • src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs: Language not supported
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Language not supported
  • src/Aspire.Cli/Resources/TemplatingStrings.Designer.cs: Language not supported
  • src/Aspire.Dashboard/Resources/ConsoleLogs.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)

tests/Aspire.Dashboard.Tests/ResourceOutgoingPeerResolverTests.cs:220

  • [nitpick] The method name TryResolvePeerCore suggests this is an internal implementation detail. Consider if this should be called TryResolvePeerNameCore to match the original method name pattern.
        return ResourceOutgoingPeerResolver.TryResolvePeerCore(resources, attributes, out peerName, out _);

@davidfowl davidfowl merged commit 5447e45 into release/9.4 Jul 19, 2025
255 checks passed
@davidfowl davidfowl deleted the backport/pr-10422-to-release-9.4 branch July 19, 2025 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants